| Summary: | make usage of mmap optional | ||
|---|---|---|---|
| Product: | fontconfig | Reporter: | Oswald Buddenhagen <ossi> |
| Component: | library | Assignee: | Akira TAGOH <akira> |
| Status: | RESOLVED FIXED | QA Contact: | Behdad Esfahbod <freedesktop> |
| Severity: | major | ||
| Priority: | medium | CC: | akira, fontconfig-bugs, freedesktop, freedesktop-news, hans |
| Version: | 2_1 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Oswald Buddenhagen
2011-07-16 06:42:17 UTC
This is really nasty... What kind of optional do you think would fix the problem? Who decides whether to use mmap() or read()? i've been wondering, too. the quick hack would be just having an environment variable to control it and the screensaver would directly set it. the right solution would be some proper api which would be used by the next higher level, in this case qt. that one in turn would have to expose an api to disable all kinds of mmaps. Or simply do that for NFS cachedirs? that may be an option, though keeping the list of nfs-(un)save FSs current is a bit challenging. it's unfortunate that there is no standardized interface to query "mmap-safety" of particular files afaik ... Quick question. We are hitting this problem often; will fontconfig still work if I just drop the <cachedir>~/.fontconfig</cachedir> part from fontconfig (on our local installs.) Will this just result in a slowdown (uncached font information?) My concern is that this will break per-user ~/.fonts.conf and we have a lot of those; breaking them would be bad. I have another hack where most homedirs have a .cache symlink that points to local disk; but I want to avoid relying on it. -A Avoiding the cache is not good. Redirect them to /tmp or something, yeah. *** Bug 34621 has been marked as a duplicate of this bug. *** Note that just fixing fontconfig is not enough. Font files are mmap()ed by FreeType, and used by applications. Many many other cache files are also mmap()ed. We may want to have something like FcStatFS() that calls statfs() on Linux and similar for other platforms. we can check if the cachedir is mounted on nfs, and disable mmap if it is. the proposed fix: http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz39278 I'm sure we need to polish this patch for other platforms and filesystems might causes the same problem perhaps. updated with FreeBSD and NetBSD support. *** Bug 27041 has been marked as a duplicate of this bug. *** updated a bit. just wonder how many platforms it do support so far. tested on Solaris 11 too. it seems working. Updated with adding FONTCONFIG_USE_MMAP envvar. setting true to this envvar behaves similarly without this patch. I mean it uses mmap(2) without statfs and so on if mmap(2) is available. committed into git with 7d65f9f5 In the interest of simplicity, I would remove the env var. Unless there's a real usecase to that. (In reply to comment #17) > In the interest of simplicity, I would remove the env var. Unless there's a > real usecase to that. There are some reasons. one is to provide a workaround for any other problematic filesystems that may causes similar issues. it can be patched out later though. one is to bypass a syscall when surely no need to check if it's on nfs or not. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.