Bug 39322

Summary:	poppler_document_new_from_data()'s data parameter should be const
Product:	poppler	Reporter:	Murray Cumming <murrayc>
Component:	glib frontend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-poppler_document_new_from_data-Make-the-data-paramet.patch

Description Murray Cumming 2011-07-18 02:23:31 UTC

Created attachment 49238 [details] [review]
0001-poppler_document_new_from_data-Make-the-data-paramet.patch

This patch means that application coders don't have to worry that the data will be changed and avoids the need for them to unconst.

Comment 1 Carlos Garcia Campos 2011-07-18 05:41:28 UTC

I agree, but simply adding const there would break API/ABI compatibility, right?

Comment 2 Murray Cumming 2011-07-18 23:46:21 UTC

(In reply to comment #1)
> I agree, but simply adding const there would break API/ABI compatibility,
> right?

Yes, because this is C++. Maybe you can keep this open for some future ABI break.

I didn't know how stable the API/ABI was meant to be now.

Comment 3 GitLab Migration User 2018-08-20 21:52:15 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/100.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.