Bug 3935

Summary: glib/splash backend generates 100% transparent images
Product: poppler Reporter: Dan Winship <danw>
Component: generalAssignee: Kristian Høgsberg <krh>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Dan Winship 2005-08-01 02:04:29 UTC
The splash backend version of poppler_page_copy_to_pixbuf uses "0" instead
of "255" for the alpha channel, resulting in 100% transparency. This doesn't
affect the main evince view, but it does mess up the generated thumbnails.

Index: ChangeLog
===================================================================
RCS file: /cvs/poppler/poppler/ChangeLog,v
retrieving revision 1.163
diff -u -r1.163 ChangeLog
--- ChangeLog   31 Jul 2005 09:54:04 -0000      1.163
+++ ChangeLog   31 Jul 2005 15:58:01 -0000
@@ -1,3 +1,8 @@
+2005-07-31  Dan Winship  <danw@novell.com>
+
+       * glib/poppler-page.cc (poppler_page_copy_to_pixbuf): Set alpha to
+       0xff (opaque), not 0x00.
+
 2005-07-31  Brad Hards  <bradh@frogmouth.net>

        * poppler/ArthurOutputDev.cc:  An initial version of proper
Index: glib/poppler-page.cc
===================================================================
RCS file: /cvs/poppler/poppler/glib/poppler-page.cc,v
retrieving revision 1.29
diff -u -r1.29 poppler-page.cc
--- glib/poppler-page.cc        29 Jul 2005 05:48:33 -0000      1.29
+++ glib/poppler-page.cc        31 Jul 2005 15:58:01 -0000
@@ -315,7 +315,7 @@
          dst[1] = splashRGB8G(*src);
          dst[2] = splashRGB8B(*src);
          if (pixbuf_n_channels == 4)
-           dst[3] = 0;
+           dst[3] = 0xff;
          dst += pixbuf_n_channels;
          src++;
        }
Comment 1 Kristian Høgsberg 2005-08-02 01:09:12 UTC
Thanks, patch applied.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.