Summary: | Make existing cppunittests work | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Björn Michaelsen <bjoern.michaelsen> |
Component: | Libreoffice | Assignee: | Not Assigned <libreoffice-bugs> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | caolanm, dtardon, libreoffice, sbergman, tobias.madl.dev |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=70448 | ||
Whiteboard: | EasyHack DifficultyBeginner SkillCpp target:3.7.0 target:4.2.0 target:4.4.0 | ||
i915 platform: | i915 features: | ||
Bug Depends on: | 84237 | ||
Bug Blocks: |
Description
Björn Michaelsen
2011-07-28 08:23:02 UTC
@stephan: Isnt this resolved by now? no, there's still a number of places that mention "testshl" See http://opengrok.libreoffice.org/search?q=testshl&project=core for the current list of uses of the archaic and removed testshl. Not too many of them left. http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=53cb376d74b108d783f4a40c8e23ce54b5f4fd90 can still serve as a template for conversion Taken Justin Harding 2011-11-20, expect to be finished by 2011-11-27 Deteted "Easyhack" from summary Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ffc05d9abfccac4d1dc04460fc25a9b16764a83e fdo#39625 Make existing cppunittests work Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6ffa064e7d8bfcdef815f24e2cfdb791dc960ba2 fdo#39625 Make existing cppunittests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ea421781b16b449045e66c38007374ab2f2c509 fdo#39625 Make existing cppunittests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e066e4abe7cac72d31323859e37bfa3e0af82b2 sal: fdo#39625 Make existing cppunittests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jelle van der Waa committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=550b275e634a5a16bf55cbb716f21608fa211e3e fdo#39625 Make existing cppunittests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details He i'd like to work on this bug. Its the first time I'm bug fixing on libre office, feel free to give me advices or suggestions :). Got a short question, one of the files doesn't have a makefile (test_comtools.cxx), was this on purpose or should i write one? test_comtools.cxx looks like a "forgotten" test. I see it is windows only, so can only be tested under windows and not the other platforms. If you're in a position where you can try fixing the test then sure go for it. t might turn out that the test doesn't work and that it is not worth fixing, that's a good result too, in which case submitting a patch to delete the broken and not-worth-fixing test is good too. Tobias Madl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f661c6b2b870452bf45c9fd1b7c56a8978c2482 fdo#39625 Make existing CppUnittests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tobias Madl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=18cc5cb2fdb8bca18a6c55d0a165b749f6730420 fdo#39625 Delete unused cppunittests The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tobias Madl committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=dbbd89efdeaa44421d1f2ad774c342009d881d9b fdo#39625 Make existing CppUnit tests work The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. So for further information, i now removed all occurrence of testshl. But i still can't close the ticket, because on one hand there's the /sal/qa/systools/test_comtools.cxx test, which only runs under windows, so sb with a windows maschine has to fix this. (Suggestion to change the ticket to a windows dependency ticket). On the other hand theres the /unoxml/test/domtest.cxx test, which is running at the moment, but still not with all tests in it. The problem, described in this ticket: Bug 84237 , has to be solved befor this tests can be used, or the tests have to be removed. (In reply to Tobias Madl from comment #18) > So for further information, i now removed all occurrence of testshl. But i > still can't close the ticket, because on one hand there's the > /sal/qa/systools/test_comtools.cxx test, which only runs under windows, so > sb with a windows maschine has to fix this. (Suggestion to change the ticket > to a windows dependency ticket). You could still do that yourself, put the patch to gerrit (with -2 code review so someone does not push it too soon) and ask on IRC to run buildbot on it. Maybe it would work :) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.