Bug 39639

Summary:	[EasyHack] Fix duplicate longname IDs
Product:	LibreOffice	Reporter:	Björn Michaelsen <bjoern.michaelsen>
Component:	Libreoffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:	EasyHack DifficultyBeginner SkillScript
i915 platform:		i915 features:

Description Björn Michaelsen 2011-07-28 10:02:08 UTC

=== Fix duplicate longname IDs ===

'''Background''': Near the end of the build you get warnings like

warn: two longnames have the same ID: HID_BG_BTN_IMG4 and HID_BG_BTN_IMG14 share ID 34300

In the particular case above I fail to see that it would anything except a typo in /components/wizards/util/hidother.src . In other cases the warnings might be caused by intentional duplications, though. This should be investigated.

'''Skills:''' dmake, grep, patience

Comment 1 Victor Lee 2011-12-17 06:01:45 UTC

As far as I traced, HID_BG_BTN_IMG13 ~ HID_BG_BTN_IMG16 looks unused.  Here is
the reason:

1. This ID seems to be associated with the id HD_BG (34290), which is the first
id of BackgroundsDialog
(wizards/com/sun/star/wizards/web/BackgroundsDialog.java).

2. In its super class ImageListDialog, this id is incremented to 34295 and
passed to ImageList.

3. In ImageList, it increments the id on creatImage(), which is called rows*cols
times in the constructor.

4. However, the initial values give rows=3 and cols=4, and BackgroundDialog do
not change them further, so it never reaches ids after than HID_BG_BTN_IMG12.

BackgroundsDialog is used only in WebWizardDialog.

Comment 2 Jan Holesovsky 2012-04-04 09:43:38 UTC

This is fixed now:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2ba78d1ed9fca82156eebb460b398829b5a3b6db

Sorry that applying that took so long - it was forgotten :-(

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.