Bug 39763

Summary:	autogen.sh should check pkg-config availability
Product:	HarfBuzz	Reporter:	suzuki toshiya <mpsuzuki>
Component:	src	Assignee:	Behdad Esfahbod <freedesktop>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	freedesktop
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to check pkg-config availability before autoreconf

Description suzuki toshiya 2011-08-02 06:35:26 UTC

Created attachment 49838 [details] [review]
patch to check pkg-config availability before autoreconf

To generate configure script by autoconf correctly, pkg.m4 is required.
It is difficult for users to understand the error message when pkg.m4 is missing,
  http://lists.freedesktop.org/archives/harfbuzz/2011-August/001460.html
  http://lists.freedesktop.org/archives/harfbuzz/2011-August/001463.html
it is expected that autogen.sh checks pkg-config availability.
configure itself uses pkg-config too, so the dependency is not harmful.

Attachment is a patch to check pkg-config. However, if some systems separate
pkg-config command and pkg.m4 macro, further improvement is needed.

Comment 1 Behdad Esfahbod 2011-08-02 08:24:18 UTC

Humm, I'll check that pkg-config is installed.  That doesn't necessary mean that pkg.m4 is available, but it's probably good enough.

Comment 2 Behdad Esfahbod 2012-09-26 17:44:48 UTC

This is fixed already.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.