Bug 39888

Summary: [regression] Artifacts in Cogs
Product: Mesa Reporter: Sven Arvidsson <sa>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: screenshot

Description Sven Arvidsson 2011-08-06 14:12:47 UTC
Created attachment 49998 [details]
screenshot

The game "Cogs" (from the Humble Indie Bundle) no longer renders correctly (see screenshot). I haven't bisected this yet, but I'm guessing it's fallout from the glsl-to-tgsi merge?

System environment:
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- GPU: REDWOOD
-- Model: XFX Radeon HD 5670 1GB
-- Display connector: DVI
-- xf86-video-ati: 6.14.2
-- xserver: 1.10.2.902
-- mesa: 1554e69e00566bc7255b82f5ea93b1f02f1a5bb3
-- drm: 2.4.26
-- kernel: 3.0
Comment 1 Bryan Cain 2011-08-06 18:14:39 UTC
If it is a result of the glsl-to-tgsi merge, then you're in luck, since I just bought the Humble Indie Bundle yesterday.  I haven't tried Cogs yet, but I will now to see if I can reproduce your issue.
Comment 2 Bryan Cain 2011-08-06 18:34:35 UTC
This is definitely a glsl_to_tgsi problem.  For me, that screen in Cogs appears for a split second before it hits an assertion failure inside of the glsl_to_tgsi code.
Comment 3 Bryan Cain 2011-08-07 12:33:49 UTC
I've sent a patch to the mailing list that fixes this bug: http://lists.freedesktop.org/archives/mesa-dev/2011-August/010258.html
Comment 4 Sven Arvidsson 2011-08-07 13:22:52 UTC
Cogs is running fine with the patch, thanks!
Comment 5 Sven Arvidsson 2011-09-19 11:49:25 UTC
Let's close this as the patch was merged quite some time ago.

commit ffb7d02154186402f64e0b628998485309774bb8
Author: Bryan Cain <bryancain3@gmail.com>
Date:   Sun Aug 7 14:15:35 2011 -0500

    st/mesa: inline st_prepare_fragment_program in st_translate_fragment_program
    
    This reverts an unnecessary part of commit 4683529048ee and fixes misrenderi
    and an assertion failure in Cogs.
    
    Fixes freedesktop.org bug 39888.
    
    Reviewed-by: Brian Paul <brianp@vmware.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.