| Summary: | SD grabs interact badly with animated cursors | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Tom Jaeger <ThJaeger> | ||||||||||
| Component: | Server/General | Assignee: | Peter Hutterer <peter.hutterer> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | medium | CC: | h.judt, peter.hutterer | ||||||||||
| Version: | git | Keywords: | patch | ||||||||||
| Hardware: | All | ||||||||||||
| OS: | Linux (All) | ||||||||||||
| Whiteboard: | |||||||||||||
| i915 platform: | i915 features: | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tom Jaeger
2011-08-10 16:08:01 UTC
Created attachment 50108 [details] [review] hjudt's patch This bug is still present in current GIT, and the patch still applies and fixes the problem with no ill side-effects observed. Created attachment 55197 [details] [review] 0001-render-don-t-bother-with-animated-cursors-on-floatin.patch This part alone seems to fix the issue for me, can you please confirm that? Indeed, i confirm this much simpler patch fixes the problem too. commit bbb6b8c834e0e1491ca14403b5d0840dd14380d3 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Fri Jan 6 13:20:45 2012 +1000 render: don't bother with animated cursors on floating slaves (#39989) This is also on server-1.11-branch I'm sorry, but I have to reopen this bug. I thought the patch that has been committed has fixed the issue, but it still happens, though very rarely now. Unfortunately, I cannot reproduce it using the known steps and don't know what to do to make it happen. Yet, there it is and so some part still needs fixing. Would applying the complete patch from comment #1 (attachment 50108 [details] [review]) instead of the simple fix break something? Until now, I did not notice any problems using that patch. (In reply to comment #7) > I'm sorry, but I have to reopen this bug. I thought the patch that has been > committed has fixed the issue, but it still happens, though very rarely now. note that the patch caused regressions and has been reverted upstream and in 1.11. so depending on what version you're running, you may not have the patch. > Would applying the complete patch from comment #1 (attachment 50108 [details] [review] [review]) instead of > the simple fix break something? Until now, I did not notice any problems using > that patch. You most likely need http://patchwork.freedesktop.org/patch/9166/ (In reply to comment #8) > note that the patch caused regressions and has been reverted upstream and in > 1.11. so depending on what version you're running, you may not have the patch. cancel this statement, confused it with another bug. Ok, thanks. I will try the patch at the bottom of the page you mentioned and see if it helps. Testing this will take some time though, as the problem is not easy to reproduce. Created attachment 59844 [details] [review] fix-grab-animated-cursor.patch Now that the patchset is in git, I gave it another try. Unfortunately, things did not get better and I can still reproduce the bug. It *might* be that it occurs only after resuming from standby/hibernation, but I'm not sure about that. Anyway, since I need it, I've modified the original version of my previous patch so that it applies on current git. I have forgotten to apply this patch to recent xserver releases, but the issue does not happen anymore, so I believe it is finally fixed (tested with xorg-server-1.13.2). sorry, forgot to close this bug. Fixed with commit bbb6b8c834e0e1491ca14403b5d0840dd14380d3 Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Fri Jan 6 13:20:45 2012 +1000 render: don't bother with animated cursors on floating slaves (#39989) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.