| Summary: | Implement ContactInfo.SetContactInfo (somehow) | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | salut | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED MOVED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Will Thompson
2011-08-12 01:53:07 UTC
I have a work-in-progress branch for this: http://cgit.collabora.com/git/user/wjt/telepathy-salut-wjt.git/log/?h=contact-info My branch is no longer a work in progress. src/Makefile.am | 2 + src/avahi-contact.c | 48 ++---- src/connection-contact-info.c | 375 ++++++++++++++++++++++++++++++++++++++++ src/connection-contact-info.h | 38 ++++ src/connection.c | 24 ++- src/contact.c | 60 +++++++- src/contact.h | 25 ++- src/debug.c | 1 - tests/twisted/avahi/aliases.py | 161 +++++++++++++++-- tests/twisted/constants.py | 3 +- 10 files changed, 673 insertions(+), 64 deletions(-) Just for one simple interface. :( It's not strictly complete: it doesn't get contact info for yourself, and you can't set it. This is a bit messy because on Salut your contact info is set using account parameters … and those parameters can't be changed without reconnecting, at present. But we can't implement SetContactInfo() because, unless we have some way to tell MC “hey change the parameters plz” the changes would be lost. And we can't just slap the DBus_Property flag on the parameters because they aren't. :'( Well, this is annoying. I don't really have anything at all to say about this branch... Don't let it get to your head. I didn't look at every details of your changes to the tests but everything looks fine. I even gave the branch a test-ride and it seems to work. Nice. Thanks, merged. <http://cgit.freedesktop.org/telepathy/telepathy-salut/commit/?id=b81086c> Retitling for the remaining lack-of-SetContactInfo issue. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-salut/issues/30. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.