Bug 40145

Summary:	gbm.h header not found when building egldisplay.c
Product:	Mesa	Reporter:	Dave Witbrodt <dawitbro>
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	build log (gzipped)

Description Dave Witbrodt 2011-08-16 08:50:38 UTC

I was just attempting a new build from git (commit f272117d of Aug. 16, 2011) and hit this build error (truncated output for readability):


make[4]: Entering directory `../src/egl/main'
[...]
gcc -c -I../../../include -Wall -g -O2 -Wall -Wmissing-prototypes          \
-std=c99 -ffast-math -fno-strict-aliasing -Wall -g -O2  -fPIC              \
-DUSE_X86_64_ASM -D_GNU_SOURCE -DPTHREADS -DTEXTURE_FLOAT_ENABLED          \
-DHAVE_POSIX_MEMALIGN -DUSE_XCB -DGLX_INDIRECT_RENDERING                   \
-DGLX_DIRECT_RENDERING -DGLX_USE_TLS -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1  \
-DIN_DRI_DRIVER -DHAVE_ALIAS -DHAVE_MINCORE -DHAVE_LIBUDEV -DHAVE_XCB_DRI2 \
-DXCB_DRI2_CONNECT_DEVICE_NAME_BROKEN -fvisibility=hidden -D_EGL_OS_UNIX=1 \
-D_EGL_BUILT_IN_DRIVER_DRI2 -D_EGL_BUILT_IN_DRIVER_GLX -DHAVE_X11_PLATFORM \
-DHAVE_DRM_PLATFORM -D_EGL_NATIVE_PLATFORM=_EGL_PLATFORM_DRM               \
-D_EGL_DRIVER_SEARCH_DIR=\"/usr/lib/x86_64-linux-gnu/egl\" egldisplay.c    \
-o egldisplay.o
[...]
egldisplay.c:55:17: fatal error: gbm.h: No such file or directory
compilation terminated.
make[4]: *** [egldisplay.o] Error 1


(I build much more of Mesa than I actually use, so several times a year I find bugs like this.  ;-)

I am not a developer, so I do not know The Right Way to fix this.  I experimented with patching 'Makefile' in src/egl/main as follows and got a successful build:


--- Makefile~	2011-08-16 08:37:13.000000000 -0400
+++ Makefile	2011-08-16 11:34:51.934413785 -0400
@@ -7,7 +7,7 @@
 EGL_MAJOR = 1
 EGL_MINOR = 0
 
-INCLUDE_DIRS = -I$(TOP)/include
+INCLUDE_DIRS = -I$(TOP)/include -I$(TOP)/src/gbm/main
 
 HEADERS = \
 	eglcompiler.h \


I am attaching the full build output for reference.


HTH,
Dave W.

Comment 1 Dave Witbrodt 2011-08-16 08:54:45 UTC

Created attachment 50276 [details]
build log (gzipped)

Build log failed to attach on first try (maybe too big), so trying again with a compressed version.

Comment 2 Benjamin Franzke 2011-08-16 10:33:16 UTC

Thanks, fixed with commit 61d2dfbe488cf5de5881c20fe1ead97f2ab5dabb.

Comment 3 Dave Witbrodt 2011-08-16 18:42:45 UTC

> ---  Comment #2 from Benjamin Franzke <benjaminfranzke@googlemail.com>  
>2011-08-16 10:33:16 PDT ---

> Thanks, fixed with commit  61d2dfbe488cf5de5881c20fe1ead97f2ab5dabb.

Works good.  Thanks!


DW

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.