Bug 40158

Summary: [i965] assign instead of compare src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp:1352
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Drivers/DRI/i965Assignee: Eric Anholt <eric>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: git   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2011-08-16 20:34:14 UTC 
mesa: 7125f1e87df359be4aad1d801b633146eeac7292 (master)

This is from a Coverity defect report.

src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
  1314  void
  1315  vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src,
  1316                                const struct glsl_type *type, bool predicated)
...
  1351     /* Do we need to worry about swizzling a swizzle? */
->1352     assert(src->swizzle = BRW_SWIZZLE_NOOP);
  1353     src->swizzle = swizzle_for_size(type->vector_elements);
Comment 1 Chris Wilson 2011-09-30 14:02:08 UTC 
commit ebca47af8507e0fc3f03d6c0f49be6b2d4d9a8a4
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Sep 30 21:58:59 2011 +0100

    i965: Assign instead of compare inside assert
    
    This is from a Coverity defect report.
    
    src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
      1314  void
      1315  vec4_visitor::emit_block_move(dst_reg *dst, src_reg *src,
      1316                                const struct glsl_type *type, bool
    predicated)
    ...
      1351     /* Do we need to worry about swizzling a swizzle? */
    ->1352     assert(src->swizzle = BRW_SWIZZLE_NOOP);
      1353     src->swizzle = swizzle_for_size(type->vector_elements);
    
    Reported-by: Vinson Lee <vlee@vmware.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40158
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 Vinson Lee 2011-11-05 22:45:58 UTC 
mesa: adb7f1351e4c231184a6355573c01c7780135342 (master)

Verified fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.