| Summary: |
SASLAuthentication.AbortSASL() is not detailed enough and the reason argument is unused |
| Product: |
Telepathy
|
Reporter: |
Marco Barisione <marco.barisione> |
| Component: |
tp-spec | Assignee: |
Telepathy bugs list <telepathy-bugs> |
| Status: |
RESOLVED
MOVED
|
QA Contact: |
Telepathy bugs list <telepathy-bugs> |
| Severity: |
normal
|
|
|
| Priority: |
medium
|
|
|
| Version: |
git master | |
|
| Hardware: |
Other | |
|
| OS: |
All | |
|
| Whiteboard: |
|
|
i915 platform:
|
|
i915 features:
|
|
|---|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
The Channel.Interface.SASLAuthentication has an AbortSASL() method that allow to stop the SASL process. The first argument is the reason to abort and currently it can be Invalid_Challenge or User_Abort. Suppose the auth channel handler does the actual authentication through an external authentication service and this fails for some other reason (for instance a network error), what is it going to pass to AbortSASL()? Also notice that the reason is not used for anything else; once the CM gets the reason it doesn't do much with it. We should get a way to properly pass a real error to the CM when we call AbortSASL() and be able to propagate it to the other components. Considering that the reason argument is basically useless I propose to deprecate AbortSASL() and add a new TerminateSASL(s: Error, s: Debug_Message), where Error is a normal D-Bus error string. The SASLError property would be then set to Error. For compatibility CMs can implement AbortSASL(Invalid_Challenge, msg) as equivalent to TerminateSASL("ofT.Error.ServiceConfused", msg) and AbortSASL(User_Abort, msg) as "ofT.Error.Cancelled", msg). Comments? (As a side note, ar the moment the SASLError property seems to be useless in Gabble as it always says it was an authentication error.)