Bug 40418

Summary: xdg-terminal fails to open terminal on generic desktop
Product: Portland Reporter: Wladyslaw Zbikowski <EmbeddedLinuxGuy>
Component: xdg-utilsAssignee: Portland Bugs <portland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch: launch terminal from generic desktop

Description Wladyslaw Zbikowski 2011-08-27 08:27:19 UTC 
Created attachment 50615 [details] [review]
Patch: launch terminal from generic desktop

This patch fixes three issues:

1. As in Bug 32927, https://bugs.freedesktop.org/show_bug.cgi?id=32927
   output of `which` was mistakenly directed to /dev/null

2. The terminal program was never actually exec'd

3. In the case where TERM=dumb or some other non-executable, we should
    fall back on xterm.
Comment 1 Rex Dieter 2011-08-27 08:57:48 UTC 
fixing 'which' is good.

and trying an xterm last-chance fallback is probably ok, but assuming xterm is present and usable, is not, imo.

And, in the future, please post patches against .in source files, not the processed output.
Comment 3 Wladyslaw Zbikowski 2011-08-27 09:29:39 UTC 
Great, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.