Bug 40584

Summary: Syntax error in configure
Product: colord Reporter: Vincent Untz <vuntz>
Component: daemonAssignee: Richard Hughes <richard>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vincent Untz 2011-09-02 10:02:16 UTC
I see this in my buildlog.

checking for sane/sane.h... yes
./configure: line 16534: test: too many arguments
checking for vapigen... /usr/bin/vapigen

Apparently, line 16534 is this line:

    if test $enable_sane = "yes" -a $has_sane = "no"; then
Comment 1 Richard Hughes 2011-09-03 09:07:07 UTC
Can you try patching configure.ac something like this please, and retest:

diff --git a/configure.ac b/configure.ac
index 0ca8a88..d87be93 100644
--- a/configure.ac
+++ b/configure.ac
@@ -207,6 +207,8 @@ if test x$enable_sane != xno; then
                        AC_SUBST(SANE_CFLAGS)
                        AC_SUBST(SANE_LIBS)
                fi
+               echo enable_sane=$enable_sane
+               echo has_sane=$has_sane
                if test $enable_sane = "yes" -a $has_sane = "no"; then
                        AC_MSG_ERROR([--enable-sane was specified and SANE was not found])
                fi

Thanks dude!

Richard.
Comment 2 Vincent Untz 2011-09-03 09:58:48 UTC
enable_sane=
has_sane=yes
Comment 3 Richard Hughes 2011-09-04 09:46:09 UTC
commit 90c06eb5077ebd4e9711cbf4a7f8f6da5db146ba
Author: Richard Hughes <richard@hughsie.com>
Date:   Sun Sep 4 17:45:24 2011 +0100

    Fix a syntax error in configure if the distro does not ship a sane .pc file
    
    Resolves https://bugs.freedesktop.org/show_bug.cgi?id=40584


Can you retest with a clean master please. Thanks dude.
Comment 4 Vincent Untz 2011-09-04 10:20:47 UTC
Works fine (although the commit log sounds wrong as I don't think it's related to a .pc file; it's just that AC_ARG_ENABLE() doesn't set enable_sane to yes by default, I guess.)

Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.