Bug 40662

Summary:	moc files still in tarball (0.6.18)
Product:	PackageKit	Reporter:	Vincent Untz <vuntz>
Component:	packagekit-qt	Assignee:	Richard Hughes <richard>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Really do not distribute moc files

Description Vincent Untz 2011-09-06 15:58:24 UTC

I just downloaded 0.6.18, and the .moc files (that shouldn't be distributed, according to f9f250b0d46ee5833fa35117a295e380550d1bf0) are in there.

Of course, it makes the build fail for the openSUSE package (but removing them solves that).

I must admit I'm not sure why they are distributed, though.

Comment 1 Richard Hughes 2011-09-07 00:50:59 UTC

I've got not idea why they're in the tarball. The mocfiles are not in EXTRA_DIST and the moc.mk snippet doesn't add anything to the dist list. Do you have any idea who can help in this problem? Thanks dude.

Comment 2 Vincent Untz 2011-09-07 02:39:58 UTC

Created attachment 50951 [details] [review]
Really do not distribute moc files

My first investigation yesterday lead to a "why does the world hate us?" conclusion ;-) But I think this patch should make it. We only care about the .cpp/.h files in the SOURCES variable.

This applies to PACKAGEKIT_0_6_X, but should be easy to port to master :-)

Comment 3 Richard Hughes 2011-09-07 08:59:40 UTC

Pushed, thanks dude!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.