Bug 4074

Summary:

_*_SOURCE shoult not be defined in FreeBSD (and probably quite every other non-GLIBC system, too)

Product:

xorg

Reporter:

Diego Elio Pettenò <flameeyes>

Component:

* Other

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

dberkholz

Version:

unspecified

Hardware:

Other

OS:

FreeBSD

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

4429

Attachments:

Description	Flags
configure-ac-no-source-on-freebsd.patch	none

Description Diego Elio Pettenò 2005-08-14 07:14:06 UTC

I found these problems while building xorg-server on Gentoo/FreeBSD: 
 
Both xf86bigfonts.c and shm.c in Xext directory tries to use SIGSYS macro, but 
this is missing because __BSD_VISIBLE is not defined to '1'. 
This define needs to be placed at the start of the files. 
 
Also xf86bigfonts.c needs to include sys/param.h unconditionally (instead of 
conditionally as it does already) because it searches for PAGE_SIZE. 
 
I'll attach a patch as soon as I have the build complete this time. 
 
HTH, 
Diego

Comment 1 Diego Elio Pettenò 2005-08-14 07:49:46 UTC

Seems like there are *a lot* of places where __BSD_VISIBLE is required to be 1 
in all the xorg-server codebase. 
Tracking file by file is not effective, maybe it should just be defined 
somewhere in config.h-like header, but I don't know the current structure 
enough to do this.

Comment 2 Diego Elio Pettenò 2005-08-19 16:53:09 UTC

Added block over release tracker.

Comment 3 Daniel Stone 2005-08-28 06:05:13 UTC

i guess you're using something like uClibc -- not glibc?  this would appear to
be an _XOPEN_SOURCE problem, in which case we don't need to test for OS in
configure.ac, but test for C library.  *vomits through hand*

Comment 4 Diego Elio Pettenò 2005-08-28 06:12:05 UTC

Quoting from first comment: 
> I found these problems while building xorg-server on Gentoo/FreeBSD: 
 
It's using FreeBSD's libc, as it's FreeBSD (see also OS field). There's no way 
that I can possibly use glibc in a FreeBSD system (that would be a 
GNU/kFreeBSD system, and it's way different).

Comment 5 Diego Elio Pettenò 2005-09-12 23:56:35 UTC

Whatever it can be said, this seems still to be a showstopper on FreeBSD. 
I'll try to take a look if removing the _*_SOURCE define from freebsd os will 
work, as the config for FreeBSD wasn't defining any of them and worked fine 
without having to define __BSD_VISIBLE (that, according to sys/cdefs.h, should 
be defined if neither __C99_SOURCE nor __ANSI_SOURCE are defined).

Comment 6 Diego Elio Pettenò 2005-09-13 00:52:08 UTC

Changing summary according, the problem is indeed with the _*_SOURCE that are 
defined in configure.ac. 
 
The attached patch to configure.ac makes it possible to avoid defining 
__BSD_VISIBLE=1 . 
This also fix bug #4076 .

Comment 7 Diego Elio Pettenò 2005-09-13 00:52:49 UTC

Created attachment 3248 [details] [review]
configure-ac-no-source-on-freebsd.patch

Comment 8 Diego Elio Pettenò 2005-09-13 00:53:17 UTC

*** Bug 4076 has been marked as a duplicate of this bug. ***

Comment 9 Eric Anholt 2005-09-14 19:59:07 UTC

Fixed this one a couple of days ago.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.