|Summary:||Make WockyMuc API more like the rest of Wocky|
|Product:||Wocky||Reporter:||Jonny Lamb <jonny.lamb>|
|Component:||General||Assignee:||Telepathy bugs list <telepathy-bugs>|
|Status:||NEW ---||QA Contact:||Telepathy bugs list <telepathy-bugs>|
|i915 platform:||i915 features:|
Description Jonny Lamb 2011-09-12 04:36:06 UTC
I don't like things like: const gchar * wocky_muc_jid (WockyMuc *muc); const gchar * wocky_muc_user (WockyMuc *muc); WockyMucRole wocky_muc_role (WockyMuc *muc); WockyMucAffiliation wocky_muc_affiliation (WockyMuc *muc); GHashTable * wocky_muc_members (WockyMuc *muc); There's probably more. Let's fix it.
Comment 1 Will Thompson 2011-10-17 04:22:33 UTC
WockyMuc uses time_t for timestamps. Telepathy at large uses gint64. Maybe WockyMuc should use GDateTime?
Comment 2 Danielle Madeley 2011-10-17 05:09:17 UTC
(In reply to comment #1) > WockyMuc uses time_t for timestamps. Telepathy at large uses gint64. Maybe > WockyMuc should use GDateTime? I have half a branch for this.
Comment 3 Danielle Madeley 2011-10-17 20:01:23 UTC
http://cgit.collabora.com/git/user/danni/wocky.git/log/?h=wocky-muc-gdatetime http://cgit.collabora.com/git/user/danni/telepathy-gabble.git/log/?h=wocky-muc-gdatetime It would be nice to remove GTimeVal usage from Wocky, because it's going to be deprecated at some point, but I think we should wait to see if someone just adds iso8601 support to GDateTime (filed as https://bugzilla.gnome.org/show_bug.cgi?id=662060).
Comment 4 Will Thompson 2011-11-07 01:49:25 UTC
Both branches look good!