Bug 40860

Summary: [bisected] piglit "spec/OES_compressed_paletted_texture/invalid formats" fails
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Mesa coreAssignee: mesa-dev
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: medium CC: ajax
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: mesa: Don't expose compressed paletted formats via GL_{NUM_,}COMPRESSED_TEXTURE_FORMATS

Description fangxun 2011-09-14 01:02:32 UTC 
System Environment:
--------------------------
Arch:           i386
Platform:       huronriver 
Libdrm:         (master)2.4.26-3-g2acaf160df584a5ef7b5c5b84819389948cd97ad
Mesa:           (master)f97acf40155a5d63a70ac6875df8128cb91d2369
Xserver:         (master)xorg-server-1.11.0
Xf86_video_intel:   (master)2.16.0-45-g6b1ed58d63e9ac80d7d028fa3036633436154816
Kernel_unstable:  (drm-intel-next)c6a389f123b9f68d605bb7e0f9b32ec1e3e14132

Bug detailed description:
------------------------- 
It happens on pineview, ironlake and sandybridge. 
Bisect find faf5d6584b9d75a10987c4460b376af7d1e4d496 is the first bad commit.
commit faf5d6584b9d75a10987c4460b376af7d1e4d496
Author:     Adam Jackson <ajax@redhat.com>
AuthorDate: Thu Sep 8 13:34:53 2011 -0400
Commit:     Adam Jackson <ajax@redhat.com>
CommitDate: Thu Sep 8 13:40:06 2011 -0400

    gles: Fix glGet(GL_{NUM_,}COMPRESSED_TEXTURE_FORMATS_ARB)

    We'd still accept the GL_PALETTE[48]_* formats in glCompressedTexImage2D,
    but they wouldn't be listed if you queried whether they were supported.

    Signed-off-by: Adam Jackson <ajax@redhat.com>

Reproduce steps:
----------------
1. start X
2. ./arb_texture_compression-invalid-formats paletted
Comment 1 Ian Romanick 2011-09-14 09:54:30 UTC 
Created attachment 51205 [details] [review]
mesa: Don't expose compressed paletted formats via GL_{NUM_,}COMPRESSED_TEXTURE_FORMATS

Nothing about GL_OES_compressed_paletted_texture should be exposed *anywhere* except OpenGL ES 1.x.
Comment 2 Ian Romanick 2011-09-20 15:43:53 UTC 
Fix by the following commit in Mesa master:

commit 011e946cb09993a9b298358188736394241bbb03
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Wed Sep 14 11:49:09 2011 -0500

    mesa: Don't expose compressed paletted formats via GL_{NUM_,}COMPRESSED_TEXTURE_FORMATS
    
    Fixes a bug introduced by commit faf5d65.  These formats should only
    be exposed in OpenGL ES 1.x.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Cc: Xun Fang <xunx.fang@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40860
Comment 3 fangxun 2011-09-23 01:14:03 UTC 
Verified with mesa master commit 51f641291d19d05acf04f08dd51215c2702a1695.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.