Bug 41037

Summary: High level API for SASLAuthentication
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: tp-glibAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: enhancement    
Priority: medium CC: xclaesse
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=sasl-41037
Whiteboard:
i915 platform: i915 features:

Comment 1 Guillaume Desmottes 2012-09-19 13:55:28 UTC
I'd be interested implementing this to simplify empathy-auth-client's code.

Also, if we are going to support the 'password' parameter in next it would be
good to have more helper code in tp-glib.

A sensible name for the TpChannel sub-class could be TpServerAuthenticationChannel, or maybe TpServerAuthChannel?

As stated in the documentation of
http://telepathy.freedesktop.org/spec/Channel_Interface_SASL_Authentication.html
this API could, in theory, be implemented on a different kind of channel (not
a Type.ServerAuthentication). Should I then implement the SASL API on top of
TpChannel instead of TpServerAuthenticationChannel?
Comment 2 Guillaume Desmottes 2012-10-01 11:05:58 UTC
I implemented this in http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=sasl-41037

I also ported Empathy http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=sasl-api
and Phoenix http://cgit.collabora.com/git/user/cassidy/telepathy-phoenix.git/log/?h=auth (blocked by introspection bugs).

Also, I'm wondering if it would make sense to have an higher level API taking care of watching the SASL status and calling AcceptSasl() or AbortSasl() directly. Both Empathy and Phoenix are doing it themself.
Comment 3 Xavier Claessens 2012-10-01 11:23:42 UTC
I would include empathy-sasl-mechanisms.c
Comment 4 Guillaume Desmottes 2012-10-01 11:49:47 UTC
(In reply to comment #3)
> I would include empathy-sasl-mechanisms.c

Ideally, the vendor specific code should be in the CM, see bug #37376
Comment 5 GitLab Migration User 2019-12-03 20:38:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/71.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.