Bug 41483

Summary:	an alternative approach for faster rendering using GL/GLES with None AA or default AA
Product:	cairo	Reporter:	Henry Song <hsong>
Component:	gl backend	Assignee:	cairo-bugs mailing list <cairo-bugs>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	enhancement
Priority:	medium	CC:	mrobinson
Version:	1.10.3
Hardware:	All
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	use stencil buffer for clipping support basic fill, incremental patch following bug id 41482

Description Henry Song 2011-10-05 09:04:09 UTC

Created attachment 52015 [details] [review]
use stencil buffer for clipping

This the second patch for clipping using stencil buffer, following submitted bug id 41482.

Comment 1 Chris Wilson 2011-10-11 04:12:14 UTC

Clipping is a little more complicated than that. ;-) You need to compute the intersection between the clip->boxes and the nested clip->paths.

As always it may be interesting to compare the cost of geometric clipping versus stencil buffer fill rates. And for aligned clips (ie clip regions) it still may be even faster to keep using scissors.

Comment 2 Henry Song 2011-10-11 17:20:16 UTC

Created attachment 52244 [details] [review]
support basic fill, incremental patch following bug id 41482

implements basic fill with constant color for MSAA compositor.  This is the second patch in MSAA cairo/gles backend.

Comment 3 Henry Song 2011-10-11 17:33:38 UTC

The second patch implements intersected clipping correctly as commented by Chris

Comment 4 Henry Song 2011-10-11 17:36:31 UTC

The second patch is about fill with constant color, sorry for previous wrong comments on clipping

Comment 5 Chris Wilson 2011-10-12 04:36:49 UTC

The source is not handled at all by the vbo. The first patch did at least pass the color components for the solid fill per-vertex, but here I would expect to see a call to setup the source operand in begin_tristrip.

Comment 6 Chris Wilson 2011-10-13 07:35:11 UTC

Applied, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.