Bug 41617

Summary:	Add localization comments to language indicator strings in base.xml.in
Product:	xkeyboard-config	Reporter:	Rimas Kudelis <rq>
Component:	General	Assignee:	xkb
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	The patch

Description Rimas Kudelis 2011-10-09 08:49:07 UTC

Created attachment 52142 [details] [review]
The patch

As discussed on IRC, this patch adds L10n comments to the <_shortDescription>'s of keyboard layouts in base.xml.in.

As a bonus, it replaces a few tabs in the file with spaces, as spaces seems to be the convention in the file.

Comment 1 Rimas Kudelis 2011-10-09 08:53:18 UTC

A few things I have noticed:
* Persian and Afghani share the same shortDescription 'fa'
* Belorussian and Belgian also share the same shortDescription 'be'

I am not sure whether or not any of this is intentional, so I left the strings as they are.

Also, it looks like there is no need to repeat the comment for each occurrence of the same translatable string – a single comment is enough. I figured this out after adding the comments to all occurrences though, and couldn't decide what the best strategy to place them would be, so I left them all intact.

Comment 2 Sergey V. Udaltsov 2011-10-09 08:55:11 UTC

Thanks, committed! Hopefully translators would be happy

Comment 3 Sergey V. Udaltsov 2011-10-09 08:56:02 UTC

> * Persian and Afghani share the same shortDescription 'fa'
Correct. Farsi.
> * Belorussian and Belgian also share the same shortDescription 'be'
Will fix Belorussian to 'by'

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.