Bug 4162

Summary:	outdated comments in cairo-surface.c
Product:	cairo	Reporter:	Christian Biesinger <cbiesinger>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high
Version:	0.9.3
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch

Description Christian Biesinger 2005-08-20 16:15:56 UTC

From Message-ID: <42F55919.7070508@web.de>

Some of the comments in cairo-surface.c are outdated / refer to the wrong
function (copy & paste bug, I assume). The attached patch fixes them.

This version of the patch fixes a few more cases than the one sent to the
mailing list, and it also describes the semantics of fallback drawing better (I
hope I got it right).

Comment 1 Christian Biesinger 2005-08-20 16:16:18 UTC

Created attachment 2945 [details] [review]
patch

Comment 2 Owen Taylor 2005-08-21 08:24:55 UTC

Thansk for the patch. I didn't really like the paragraph:

 * The surface returned by this function should contain the image bits that
 * @surface contains in the rectangle. _cairo_surface_release_dest_image should
 * copy the data back with the equivalent of a SOURCE operator. The returned
 * image surface should be an ARGB surface if @surface supports destination
 * alpha, an RGB surface otherwise.

Sounds like more magic is permissable than it is... if @surface is 16-bit
565, than the new surface should be 16-bit 565 as well. I added a sentence
to @image_out description instead:

 *    If a new surface is created, it should have the same channels and depth
 *    as @surface so that copying to and from it is exact.

2005-08-21  Owen Taylor  <otaylor@redhat.com>

        * src/cairo-surface.c: Improve the documentation of internal
        functions. (Based on a patch from Christian Biesinger, #4162)

Comment 3 Carl Worth 2005-08-22 17:14:45 UTC

Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.