Summary: |
Accessors in Channel and other D-Bus proxies which are initialized from immutable properties should return the immutable property data immediately after construction |
Product: |
Telepathy
|
Reporter: |
Olli Salli <ollisal> |
Component: |
tp-qt | Assignee: |
Telepathy bugs list <telepathy-bugs> |
Status: |
RESOLVED
MOVED
|
QA Contact: |
Telepathy bugs list <telepathy-bugs> |
Severity: |
enhancement
|
|
|
Priority: |
medium
|
CC: |
ollisal
|
Version: |
git master | |
|
Hardware: |
Other | |
|
OS: |
All | |
|
Whiteboard: |
|
i915 platform:
|
|
i915 features:
|
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Currently, Channel only populates the accessors like channelType() from the immutable properties when FeatureCore preparing is started. This makes us and others write code like the following in the handleChannels() implementation of the internal SimpleStreamTubeHandler class: > // TODO: if Channel ever starts utilizing its immutable props for the immutable > // accessors, use Channel::channelType() here > const QString channelType = > chan->immutableProperties()[QLatin1String( > TELEPATHY_INTERFACE_CHANNEL ".ChannelType")].toString(); I believe a similar situation exists for some other classes too. I specifically fixed ChannelRequest to work sensibly in this regard last year.