Bug 41814

Summary:	[Patch] gtk-tools: port to gtk3
Product:	systemd	Reporter:	Marc-Antoine Perennou <Marc-Antoine>
Component:	general	Assignee:	Thomas H.P. Andersen <phomes>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	a9016009
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	gtk-tools: port to gtk3 Port to Gtk3

Description Marc-Antoine Perennou 2011-10-15 07:29:26 UTC

Created attachment 52364 [details] [review]
gtk-tools: port to gtk3

This is kinda trivial.
Maybe would you prefer a configure switch to choose between gtk2 and gtk3 ?

Comment 1 Andre Klapper 2012-04-02 05:02:34 UTC

ping - can this get a review?

Comment 2 Lennart Poettering 2012-07-20 14:12:11 UTC

Looks good to me, but we split off the UI bits of systemd into a separate repo. Could you please rebase your patches, will merge them right away, then!

Comment 3 Thomas H.P. Andersen 2012-11-17 00:03:40 UTC

Created attachment 70177 [details] [review]
Port to Gtk3

I rebased the patches but they needed some work still.

The WrapLabel class does not work at all in a height-for-width world so it had to go. GtkLabel works well enough in gtk3 with both wrap and resize.

GtkTable was replaced with the much nicer GtkGrid, + various other deprecation-fixes.

Comment 4 Thomas H.P. Andersen 2012-11-17 00:09:22 UTC

Pushed to master:
http://cgit.freedesktop.org/systemd/systemd-ui/commit/?id=a7f32df98d0fb863b43c04e8664d709f701f2001

Thanks Marc-Antoine!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.