Bug 41822

Reviewing the LICENSE file and the licenses in the code a bit more closely, I notice the following issues

1) I think the LICENSE file could be more clear that libsamplerate is an 
   optional dependency and that the license of libpulsecore is affected if 
   you build with it.  The way it reads, it sounds like libpulsecore is GPL
   regardless.

2) I notice that these files are under the GPL:

   - pulseaudio-1.0/src/modules/bluetooth/proximity-helper.c
   - pulseaudio-1.0/src/modules/bluetooth/a2dp-codecs.h:

   The proximinity-helper is a binary delivered to libexec, so this is okay.  
   However, the LICENSE file should probably highlight that it ships this GPL
   binary.

   More seriously, the a2dp-codecs.h file is included in the following 
   bluetooth module files bluetooth-util.c and module-bluetooth-device.c 

   Is this an error, or should the LICENSE file highlight that building the 
   bluetooth module also affects the PulseAudio license.

3) The LICENSE file highlights that the echo-cancel module is under a more
   permissive license.  I notice that some code uses the MIT license.  Should
   this be highlighted as well if you are going to highlight more permissive
   licensing in the module?

   - pulseaudio-1.0/src/modules/reserve-monitor.c
   - pulseaudio-1.0/src/modules/reserve.c
   - pulseaudio-1.0/src/pulsecore/rtkit.c

   Also, this file is under a more permissive Sun Public Domain license:
   - pulseaudio-1.0/src/pulsecore/g711.c:

(In reply to comment #1)
> Reviewing the LICENSE file and the licenses in the code a bit more closely, I
> notice the following issues
> 
> 1) I think the LICENSE file could be more clear that libsamplerate is an 
>    optional dependency and that the license of libpulsecore is affected if 
>    you build with it.  The way it reads, it sounds like libpulsecore is GPL
>    regardless.

Indeed. Patches welcome.

> 2) I notice that these files are under the GPL:
> 
>    - pulseaudio-1.0/src/modules/bluetooth/proximity-helper.c
>    - pulseaudio-1.0/src/modules/bluetooth/a2dp-codecs.h:
> 
>    The proximinity-helper is a binary delivered to libexec, so this is okay.  
>    However, the LICENSE file should probably highlight that it ships this GPL
>    binary.
> 
>    More seriously, the a2dp-codecs.h file is included in the following 
>    bluetooth module files bluetooth-util.c and module-bluetooth-device.c 
> 
>    Is this an error, or should the LICENSE file highlight that building the 
>    bluetooth module also affects the PulseAudio license.

Thanks for the review. It does indeed seem like an oversight. We should have been more careful in updating the LICENSE file when new code is imported. Again, patches welcome.

> 3) The LICENSE file highlights that the echo-cancel module is under a more
>    permissive license.  I notice that some code uses the MIT license.  Should
>    this be highlighted as well if you are going to highlight more permissive
>    licensing in the module?
> 
>    - pulseaudio-1.0/src/modules/reserve-monitor.c
>    - pulseaudio-1.0/src/modules/reserve.c
>    - pulseaudio-1.0/src/pulsecore/rtkit.c
> 
>    Also, this file is under a more permissive Sun Public Domain license:
>    - pulseaudio-1.0/src/pulsecore/g711.c:

Hmm, not that important, but if echo-cancel gets mentioned, I suppose we could as well be complete in the LICENSE file.

I already proposed to gather all imported code into a separate dir (e.g. src/ext/) to keep a clear separation between our code and external code, for licensing and updating issues. But that idea didn't seem to get traction with the other devs.

Created attachment 52542 [details] [review]
suggested patch to improve LICENSE information.


Here is a patch that I think makes the LICENSE file more clear.  Obviously the maintainers should review to make sure it is correct and acceptable.

The wording seems OK to me but there seems to be a half finished sentence in there....

+also GPL licensed.  If the bluetooth module is built, then the
+
+So, the following PulseAudio binaries link against libpulsecore, and

Created attachment 52559 [details] [review]
updated patch

Sorry about that, here's an updated patch.

OK, we've pushed this change which we think clarifies things sufficiently and also doesn't go into precise detail about specific files as this will certainly go out of date again in the future. 

http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=d80a3cf56e4979eb5aa5bdfb8bfc03b87c72e2de

Of course we'll try to mention anything "weird" in that file and any further clarification would be welcome.

Thanks for your contribution :)