Bug 42262

Summary: [bisected] oglc shad-interactions(advanced.TestUniformStruct) fails
Product: Mesa Reporter: fangxun <xunx.fang>
Component: glsl-compilerAssignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    

Description fangxun 2011-10-26 00:51:13 UTC
System Environment:
--------------------------
Arch:           i386
Platform:       huronriver
Libdrm: (master)cc088f1721eaa5f8f1ba1932723882f92e34c39a
Mesa:           (master)faa16dc456f1f910eef24eaa23889be806b513b7
Xserver:  (master)fb84be47db7cdaff406792c08e34670e8e0cbda9
Xf86_video_intel: (master)2.16.0-205-ga18f559961135fa288dda3b94207abb0b6d4d302
Kernel:  (drm-intel-next)64a742fac3a22f57303d8f1b7e347350a1c48254

Bug detailed description:
------------------------- 
It fails on pineview, ironlake and Sandybirdge. 
Following cases also fail:
shad-interactions(advanced.TestUniformStruct)
GLSLlinker(positive.basic.uniform.strucTypeDeclaration)
GLSLlinker(positive.uniform.structure)
GLSLlinker(positive.uniform.structureOfArray)
GLSLlinker(positive.uniform.arrayOfStructure)
textureswizzle(advanced.shader.basic)
textureswizzle(advanced.shader.internalfmt)
textureswizzle(advanced.shader.targets)
textureswizzle(advanced.shader.multitex)
textureswizzle(advanced.shader.shadowtex)

Bisect shows b2572928a50ce42abc2733202d08f5a00733d707 is the first bad commit.
commit: b2572928a50ce42abc2733202d08f5a00733d707
Author:     Ian Romanick <ian.d.romanick@intel.com>
AuthorDate: Fri Sep 9 18:27:36 2011 -0700
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Tue Oct 18 17:26:38 2011 -0700

    ir_to_mesa: Generate gl_program_parameter list by walking the GLSL IR.

    Generate the program parameters list by walking the IR instead of by
    walking the list of linked uniforms.  This simplifies the code quite a
    bit, and is probably a bit more correct.  The list of linked uniforms
    should really only be used by the GL API to interact with the
    application.

    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Cc: Bryan Cain <bryancain3@gmail.com>
    Cc: Eric Anholt <eric@anholt.net>

Reproduce steps:
----------------
1. start X
2. ./oglconform  -z -s -suite all -v 2 -D 115 -test shad-interactions advanced.TestUniformStruct
Comment 1 Ian Romanick 2012-01-03 13:30:44 UTC
This test passes on SNB for me.  Are they still failing on that or other platforms for you?
Comment 2 fangxun 2012-01-03 22:46:28 UTC
It passes on SNB and other platforms now.
Comment 3 fangxun 2012-01-03 22:47:18 UTC
Verified with mesa master commit 4535874c1a6da74d9130e494d514284302e4d08e.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.