| Summary: | Doesn't advertise ContactBlocking when supported | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Guillaume Desmottes <guillaume.desmottes> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Advertise ContactBlocking if supported
Advertise ContactBlocking if supported Advertise ContactBlocking if supported actually implement ContactBlocking interface |
||
|
Description
Guillaume Desmottes
2011-10-26 06:49:36 UTC
Created attachment 52797 [details] [review] Advertise ContactBlocking if supported Comment on attachment 52797 [details] [review] Advertise ContactBlocking if supported Review of attachment 52797 [details] [review]: ----------------------------------------------------------------- Functionally, looks fine. ::: src/connection.c @@ +2819,5 @@ > + { > + const gchar *ifaces[] = > + { TP_IFACE_CONNECTION_INTERFACE_CONTACT_BLOCKING, NULL }; > + > + tp_base_connection_add_interfaces ((TpBaseConnection *) conn, ifaces); Something is funky with the indentation here. The declaration of 'ifaces' is one space further in than the function call. ::: tests/twisted/roster/test-google-roster.py @@ +296,5 @@ > ) > > + assertContains(cs.CONN_IFACE_CONTACT_BLOCKING, > + conn.Get(cs.CONN, "Interfaces", > + dbus_interface=cs.PROPERTIES_IFACE)) conn.Properties.Get(cs.CONN, "Interfaces") Created attachment 52798 [details] [review] Advertise ContactBlocking if supported Created attachment 52799 [details] [review] Advertise ContactBlocking if supported Created attachment 52800 [details] [review] actually implement ContactBlocking interface Merged to master; will be in 0.13.8. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.