Summary: | plymouth signal handlers modify linked lists resulting in frequent crashes | ||
---|---|---|---|
Product: | plymouth | Reporter: | James Hunt <james.hunt> |
Component: | general | Assignee: | Ray Strode [halfline] <rstrode> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | medium | CC: | rstrode |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
James Hunt
2011-10-26 09:33:30 UTC
ply_event_loop_watch_signal isn't just a wrapper around signal() or sigaction(). It's a command to make signal handling "safe" by keeping the actual signal handler tiny (basically just does a write() call iirc) and deferring execution of the passed in function until the main loop runs. Having said that, the SIGINT handlers are bogus code that were copy and pasted around from the early days of plymouth and should be removed. They won't get run during boot though, so they aren't the source of any of the issues your users are seeing. Okay i've dropped the SIGINT handlers: commit bb46ffb90ade92d87d82fadcea3a0243c80dea79 Author: Ray Strode <rstrode@redhat.com> Date: Fri Jun 8 15:11:52 2012 -0400 splash: drop SIGINT handlers They serve no real purpose. https://bugs.freedesktop.org/show_bug.cgi?id=42285 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.