Bug 42433

Summary:	Add wocky_node_tree_build()
Product:	Wocky	Reporter:	Jonny Lamb <jonny.lamb>
Component:	General	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED INVALID	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	will
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Jonny Lamb 2011-10-31 07:35:33 UTC

> +      WockyStanza *tmp = wocky_stanza_build (WOCKY_STANZA_TYPE_IQ,
> +          WOCKY_STANZA_SUB_TYPE_RESULT, NULL, NULL,
> +          '(', "x",
> +            ':', NS_X_DATA,
> +            '@', "type", "result",
> +            '(', "field",
> +              '@', "var", "FORM_TYPE",
> +              '@', "type", "hidden",
> +              '(', "value",
> +                '$', NS_TP_FT_METADATA_SERVICE,
> +              ')',
> +            ')',
> +            '(', "field",
> +              '@', "var", "ServiceName",
> +              '(', "value",
> +                '$', self->priv->service_name,
> +              ')',
> +            ')',
> +          ')',
> +          NULL);
> +      WockyNode *x = wocky_node_get_first_child (wocky_stanza_get_top_node
> (tmp));
> +      WockyNodeTree *tree = wocky_node_tree_new_from_node (x);
> +
> +      wocky_node_add_node_tree (file, tree);
> +      g_object_unref (tree);
> +      g_object_unref (tmp);
> 
> Ugh this is dumb. There should be a wocky_node_tree_build().

Fair.

Comment 1 Jonny Lamb 2011-10-31 07:35:48 UTC

(That was bug #42288 btw.)

Comment 2 Will Thompson 2013-04-03 10:27:33 UTC

There already is:

WockyNodeTree *
wocky_node_tree_new (const gchar *name,
  const gchar *ns,
  ...)

has always been a build spec-flavoured thing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.