Bug 42454

Summary:	remove code associated with unused icons
Product:	LibreOffice	Reporter:	Michael Meeks <michael.meeks>
Component:	Libreoffice	Assignee:	Julien Chaffraix <julien.chaffraix>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	julien.chaffraix, michael.meeks
Version:	Master old -3.6
Hardware:	Other
OS:	All
Whiteboard:	EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup target:3.7.0
i915 platform:		i915 features:
Attachments:	[PATCH] Fix for EasyHack FDO42454, remove code associated with unused icons

Description Michael Meeks 2011-10-31 13:53:54 UTC

We have a number of unused icons (cf. bug #42453) that are still mentioned in the source code, and are included. We should grok the packed image.zip to look for high-contrast cross icons, then grep the code for those icons, and remove the associated .src file entries, .hrc defines, and any code that uses them.

Hopefully there are relatively few of these now, but some remain eg. res/lx03241.png or res/sx03241.png or cmd/lc_splitparentvertical.png etc.

It'd be great to manually review, and prune these outliers: a list of files to 'git rm' and a patch to cleanup any code using them would be wonderful.

Comment 1 Gustavo Pacheco 2011-12-16 12:20:48 UTC

Created attachment 54514 [details] [review]
[PATCH] Fix for EasyHack FDO42454, remove code associated with unused icons

I have found 8 high-contrast cross icons in images.zip:
res/sx03241.png
res/lx03241.png
res/commandimagelist/lc_splitparentvertical.png
sw/res/anchor.png
sw/res/danchor.png
fpicker/res/list.png
svx/res/galimpl.png
svx/res/galimps.png

But only list.png, galimpl.png, galimps.png were referenced in the code:

fpicker/res/list.png: list.bmp (removed from /fpicker/source/office/iodlg.src in the patch)
svx/res/galimps.png: galimps.bmp (removed from svx/source/gallery2/gallery.src in the patch)
svx/res/galimpl.png: galimpl.bmp (removed from cui/source/dialogs/gallery.src in the patch)

Comment 2 Gustavo Pacheco 2011-12-16 14:52:45 UTC

Oh! =(
Really sorry Julien, I see now that the bug is assigned to you! I'm embarrassed, I did the same that the other guy did in https://bugs.freedesktop.org/show_bug.cgi?id=43058. I hope that's no problem for you. You are welcome if you have some additional information about this bug.

Comment 3 Florian Reisinger 2012-05-18 08:21:40 UTC

Removed EASYHACK from summary

Comment 4 Michael Stahl 2012-07-06 11:10:16 UTC

mmeeks, can you please take a look at the patch attached here?

Comment 5 Not Assigned 2012-07-16 13:19:42 UTC

Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6d6198393e0677710191248d6f7c9ec15d0f0e0f

Resolves: fdo#42454 'imported' gallery format doesn't appear to exist

Comment 6 Caolán McNamara 2012-07-16 13:22:43 UTC

The attached patch was basically committed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=e220f41cb2486d2ad101d98e48fbbc40c9fd08c3

Given the above list, the only remaining dodgy looking icons were
svx/res/galimpl.png
svx/res/galimps.png
digging into those, they appear to be for an "imported" gallery theme, but I can see no way to generate one of those, unless you have one already installed (gallery.sdi) and the code for it goes back to 2000, so it seems to be a pre OpenOffice.org StarOffice thing and seeing as we never migrated staroffice config dirs to OpenOffice.org (or LibreOffice of course) I think we can safely remove those too and the broken icons associated with that format.

Sooo, assuming the above list was correct, then this is now complete

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.