Bug 42460

Summary:	rtp: Set proper latency values on pulsesink/pulsesrc
Product:	Farstream	Reporter:	Arun Raghavan <arun>
Component:	RTP Plugin	Assignee:	Olivier Crête <olivier.crete>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-rtp-Set-proper-latency-values-on-pulsesink-pulsesrc.patch rtp: Tune pulsesink/pulsesrc latency values further

Description Arun Raghavan 2011-11-01 01:43:20 UTC

Created attachment 52980 [details] [review]
0001-rtp-Set-proper-latency-values-on-pulsesink-pulsesrc.patch

This sets a 50ms buffer-time on pulsesink and pulsesrc and a 25ms
latency-time on pulsesink, which should decrease the overall latency of
the audio pipeline (the current value being used is the default
buffer-time of 200ms).

The only concern here might be performance on lower-end hardware. On an
AMD C-50 processor (dual-core 1GHz) based netbook, there was no real
performance impact from this.

Comment 1 Olivier Crête 2011-11-01 11:53:11 UTC

Committed.

Don't worry too much about performance, on the N900, we have buffer-time at 40ms.

And anyway, the default thing is for PC-class hardware. As I expect we will continue to have custom properties for embedded hardware for the foreseeable future.

Comment 2 Arun Raghavan 2011-11-21 10:38:22 UTC

Reopening -- the values I submitted were bad and would result in a couple of seconds of scratchiness at the beginning of a call on some hardware. This should be more sensible.

Comment 3 Arun Raghavan 2011-11-21 10:39:20 UTC

Created attachment 53746 [details] [review]
rtp: Tune pulsesink/pulsesrc latency values further

Comment 4 Olivier Crête 2013-03-22 19:10:46 UTC

Patch applied!

I end up putting latency-time to 20ms instead of 10ms because it halves the per-buffer CPU usage..


[pulsesink]
buffer-time=40000
latency-time=20000

[pulsesrc]
buffer-time=20000


commit 5bdb476dfe467c129cb2e50fc7bf120df7babfdd
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Fri Mar 22 15:09:29 2013 -0400

    rtp: Tune pulsesink/pulsesrc latency values further
    
    This makes for lower overall values without forcing a bunch of underruns
    at the start which we got by having pulsesink's buffer-time as
    2*latency-time.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.