| Summary: | Support for building on Android | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Alvaro Soliverez <alvaro.soliverez> |
| Component: | salut | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Use external wocky library
Android-specific files and modifications Android-specific files and modifications - fixed |
||
|
Description
Alvaro Soliverez
2011-11-02 07:17:25 UTC
Created attachment 53056 [details] [review] Android-specific files and modifications Comment on attachment 53056 [details] [review] Android-specific files and modifications Review of attachment 53056 [details] [review]: ----------------------------------------------------------------- The same comment about the name of the configure flag applies. ::: .gitignore @@ +45,4 @@ > .cvsignore > Thumbs.db > autom4te.cache > +Android.mk Surely you don't want to add Android.mk to the ignore list? Hmm. There's a hand-written Android.mk in the top level, so you don't want that to be matched by .gitignore, but the generated ones you do. Does .gitignore support something like */.gitignore ? (In reply to comment #2) > Comment on attachment 53056 [details] [review] [review] > Android-specific files and modifications > > Review of attachment 53056 [details] [review] [review]: > ----------------------------------------------------------------- > > The same comment about the name of the configure flag applies. > > ::: .gitignore > @@ +45,4 @@ > > .cvsignore > > Thumbs.db > > autom4te.cache > > +Android.mk > > Surely you don't want to add Android.mk to the ignore list? > > Hmm. There's a hand-written Android.mk in the top level, so you don't want that > to be matched by .gitignore, but the generated ones you do. Does .gitignore > support something like > > */.gitignore > > ? On building, Android.mk files are generated per each Makefile.am file (based on the Android.mk target). Those files should be ignored. We add the .gitignore clause at the same time as the one needed Android.mk, and further modications to this file are actually not ignored, so it works fine for what we need. Created attachment 53550 [details] [review] Android-specific files and modifications - fixed Fixed the hardcoded libraries I pushed a patch which combines these two patches and fixes a couple of remaining nitpicks, namely:
• not having a separate GIO_{CFLAGS,LIBS} check;
• not talking about Yell in the help string for --disable-submodules when Salut doesn't use Yell.
http://cgit.freedesktop.org/telepathy/telepathy-salut/commit/?id=f312040d789a823a66a3c044ceaf7da3064529fc
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.