Bug 42523

Summary: Support for building on Android
Product: Telepathy Reporter: Alvaro Soliverez <alvaro.soliverez>
Component: yellAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: git master   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch to build on Android
Patch to build on Android - fixed
Patch to build on Android - fixed
Support for Android - fixed

Description Alvaro Soliverez 2011-11-02 09:34:46 UTC

    
Comment 1 Alvaro Soliverez 2011-11-02 09:35:49 UTC
This patch enables building tp-yell on Android, using Android NDK and androgenizer
Comment 2 Alvaro Soliverez 2011-11-02 09:36:25 UTC
Created attachment 53063 [details] [review]
Patch to build on Android
Comment 3 Will Thompson 2011-11-10 07:23:39 UTC
Comment on attachment 53063 [details] [review]
Patch to build on Android

Review of attachment 53063 [details] [review]:
-----------------------------------------------------------------

::: telepathy-yell/Makefile.am
@@ +195,5 @@
> +	 -:CFLAGS $(DEFS) $(CFLAGS) $(DEFAULT_INCLUDES) $(INCLUDES) \
> +	  $(AM_CFLAGS) \
> +	 -:CPPFLAGS $(CPPFLAGS) $(AM_CPPFLAGS) \
> +	 -:LDFLAGS $(libtelepathy_yell_la_LIBADD) \
> +	  $(libtelepath_yell_la_LDFLAGS) -lgio-2.0 -ltelepathy-glib \

There's a typo here: "libtelepath_yell_la_LDFLAGS" is missing a y. (So how does it work, we wonder? :) )
Comment 4 Alvaro Soliverez 2011-11-11 10:50:29 UTC
Created attachment 53419 [details] [review]
Patch to build on Android - fixed

The flag was actually not required, that's why it was working :)
Comment 5 Alvaro Soliverez 2011-11-14 12:18:08 UTC
Created attachment 53556 [details] [review]
Patch to build on Android - fixed

Fixed the libs hardcoding
Comment 6 Will Thompson 2011-11-15 07:28:23 UTC
(In reply to comment #5)
> Created attachment 53556 [details] [review] [review]
> Patch to build on Android - fixed
> 
> Fixed the libs hardcoding

I think this is the patch for Gabble, not for Yell. :)
Comment 7 Alvaro Soliverez 2011-11-15 07:31:08 UTC
Created attachment 53574 [details] [review]
Support for Android - fixed

This is the correct patch, sorry

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.