|Summary:||Reset clip region when writing fallback results|
|Product:||cairo||Reporter:||Alexander Larsson <alexl>|
|Component:||win32 backend||Assignee:||cairo-bugs mailing list <cairo-bugs>|
|Status:||RESOLVED FIXED||QA Contact:||cairo-bugs mailing list <cairo-bugs>|
|i915 platform:||i915 features:|
|Bug Depends on:|
|Attachments:||Reset the clip when drawing|
Description Alexander Larsson 2011-11-11 07:27:36 UTC
Created attachment 53402 [details] [review] Reset the clip when drawing The win32 backend doesn't properly remove previous clip regions (set by e.g. show_glyphs) in release_dest_image, which caused loss of fallback rendering results.
Comment 1 Alexander Larsson 2011-11-11 07:29:54 UTC
Also, i'm not sure how this is supposed to work exactly, but it *seems* to me that show_glyphs doesn't correctly reset the clip region if passed in a NULL clip, but there is some complexity there that i don't understand, so i left this alone in my patch.
Comment 2 Alexander Larsson 2011-11-11 07:40:16 UTC
master has similar issues, but its in _cairo_win32_surface_unmap_image there.
Comment 3 Chris Wilson 2012-02-15 06:43:52 UTC
commit ae3319890eacd1c8282ca6df7b263ac74abb5f8d Author: Chris Wilson <email@example.com> Date: Sun Feb 12 11:25:07 2012 +0000 win32: Rebase on the new compositor infrastructure Try and undo all the damage that has acrued over the years by plugging into the compositor pipeline. References: https://bugs.freedesktop.org/show_bug.cgi?id=42739 References: https://bugs.freedesktop.org/show_bug.cgi?id=42821 References: https://bugs.freedesktop.org/show_bug.cgi?id=33081 Signed-off-by: Chris Wilson <firstname.lastname@example.org>