Bug 42837

Summary: [llvmpipe] piglit getteximage-format regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: Dave Airlie <airlied>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: medium CC: brianp, jfonseca
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2011-11-11 15:03:02 UTC
mesa: bf8ad170c5af58fe9f49b3ce0f92c4eda9e5d845 (master)

Run piglit getteximage-format on llvmpipe.

$ ./bin/getteximage-formats -auto
Using test set: Core formats
getteximage-formats failure: format: GL_RGB9_E5_EXT, level 1 at pixel(369, 103)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (1.000000, 1.000000, 1.000000, 1.000000)
Tolerance (0.015686, 0.015686, 0.015686, 0.250000)
getteximage-formats failure: format: GL_RGB9_E5_EXT, level 2 at pixel(421, 71)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (1.000000, 1.000000, 1.000000, 1.000000)
Tolerance (0.015686, 0.015686, 0.015686, 0.250000)
getteximage-formats failure: format: GL_R11F_G11F_B10F_EXT, level 1 at pixel(369, 103)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (1.000000, 1.000000, 1.000000, 1.000000)
Tolerance (0.300000, 0.300000, 0.300000, 0.250000)
getteximage-formats failure: format: GL_R11F_G11F_B10F_EXT, level 2 at pixel(421, 71)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (1.000000, 1.000000, 1.000000, 1.000000)
Tolerance (0.300000, 0.300000, 0.300000, 0.250000)
PIGLIT: {'result': 'fail' }
Comment 1 Vinson Lee 2011-11-11 15:09:51 UTC
4fd485666a9a52c48633d261c2fdd763d63299f5 is the first bad commit
commit 4fd485666a9a52c48633d261c2fdd763d63299f5
Author: Dave Airlie <airlied@redhat.com>
Date:   Mon Nov 7 19:22:01 2011 +0000

    llvmpipe/u_format: add support for EXT_texture_shared_exponent + EXT_packed_float
    
    These two are fairly unique types so add specific cases for decoding them.
    
    Passes piglit fbo-clear-format and fbo-generatemipmap-format tests for these
    two extensions.
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>

:040000 040000 fdc6bc64b97e0f4713d9b6a62cdd454cf7beeeda f7fd2b11561f5b63a15803d796cf6b258dcd4b90 M	src
bisect run success
Comment 2 Dave Airlie 2011-11-13 11:21:38 UTC
will take a look, not a regression in functionality, just new formats been tested and for some reason failing.
Comment 3 Dave Airlie 2011-11-14 01:36:42 UTC
should be fixed in master now
Comment 4 Vinson Lee 2011-11-14 13:49:22 UTC
mesa: fa704cc558ab321792b364dab43f1e960513bed0 (master)

Verified fixed.

getteximage-format passes on llvmpipe

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.