Bug 42980

Summary:	Duplicate icons in soffice.exe
Product:	LibreOffice	Reporter:	Pedro <pedlino>
Component:	Libreoffice	Assignee:	Andras Timar <timar74>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	medium	CC:	timar74
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Pedro 2011-11-16 02:58:57 UTC

soffice.exe contains 39 icons at 4 image size / bit depth and 1 icon at 9 image size/bit depth. This results in 165 images.

But in fact all but one are duplicated several times.

Icon 1 = 13, 17, 18, 19, 20, 27, 37
Icon 2 = 21, 28
Icon 3 = 29
Icon 4 = 22, 30
Icon 5 = 31
Icon 6 = 23, 32
Icon 7 = 33
Icon 8 = 24, 34
Icon 9 = 10, 35
Icon 11 = 36
Icon 12 = 16
Icon 14 = 26, 38
Icon 15 = 25, 39
Icon 40 is unique :)

Cleaning up all duplicates would reduce this to 14 icons for a total of 69 images.
It's not a lot of Kbytes but seems like a waste of time and resources (unless it is needed for some reason that is not obvious for a non-dev)

Comment 1 Andras Timar 2011-11-24 13:57:41 UTC

http://opengrok.libreoffice.org/xref/core/desktop/util/officeloader.rc

We need to find out, if these icons are referenced from the code. If not, they can be removed.

Comment 2 Andras Timar 2011-12-02 06:28:23 UTC

Icon indexes are used at:
- setup_native/source/win32/customactions/reg4msdoc/registrationcontextinformation.cxx
- scp2/source/*/registryitem_*.scp
  (git grep "soffice.exe," and git grep CONDITIONAL_REGISTER_DOC_EXTENSION)

In OOo most icons were different, because they made a distinction between application icons and document icons. In LibreOffice we have the same icon for example for LibreOffice Draw and for ODG documents. I think we should keep this distinction in LibreOffice, too, because it is possible, that we'll have a new icon set in the future. Some simplifications are possible, though.

Comment 3 Andras Timar 2012-01-18 04:09:46 UTC


*** This bug has been marked as a duplicate of bug 37740 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.