Bug 431

Summary: Screen shifted to left with 1400x1050 res
Product: xorg Reporter: Richard Pinnell <pinr>
Component: Driver/TridentAssignee: Alan Hourihane <alanh>
Status: RESOLVED INVALID QA Contact: Xorg Project Team <xorg-team>
Severity: major    
Priority: high CC: erik.andren, jeremyhu, raflapietra
Version: 6.7.0   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard: 2011BRB_Reviewed
i915 platform: i915 features:
Attachments:
Description Flags
Centre the screen for 1400x1050 modes none

Description Richard Pinnell 2004-04-08 09:42:41 UTC
Symptoms: The screen is shifted appox 16 pixels to the left.  The pixels missing
from the left side of the screen appear on the right hand of the screen. The
problem presents itself when 1400x1050 resolution is selected (Option
"Display1400"           "true") in xorg config.  The machine is a Toshiba Tecra
8200 running Gentoo Linux, it has a 1400x1050 lcd screen and a Trident
Microsystems CyberBlade/XP (rev 63) video card.   This problem is also present
in the XFree86's release of X11 and is registered as bug #1076.  Searches on the
internet show that the bug has been in existance for at least 2 years.  I
willing to help anyone fix the bug or test code, surely it is just a question of
changing a small amount of code in the
xc/programs/Xserver/hw/xfree86/drivers/trident/trident_drv.c file but, where?
Does anyone know? Does anyone care?
Comment 1 Richard Pinnell 2004-04-16 04:20:13 UTC
If anybody is in the slightest bit interested  I have managed to fix this bug by
doing the
following.  Locate the lines:
fullSize = (mode->HDisplay == LCD[i].display_x) 
	        && (mode->VDisplay == LCD[i].display_y);
in the trident_dac.c file and comment them out.  After recompiling the trident
driver I no longer have this very annoying problem on my Tosiba Tecra 8200.
There are still couple of minor problems however.  First the screen is now ever
so slightly off centre it is down and to the left by 5 pixels or less.  This is
of course no where near as annoying as having the left 16 bits on the right of
the screen.  Secondly the xv driver is now working in xine and mplayer but there
are thin blue lines displayed along the bottom and  left side of the video
window (not the screen). 
Has anyone got any suggestions on how I might fix these two final minor
problems.  Thanks
Comment 2 Alan Hourihane 2004-06-30 14:35:03 UTC
Created attachment 434 [details] [review]
Centre the screen for 1400x1050 modes

Thanks for this report Richard.

Can you try the attached patch and let me know if it still cures your problem.
Comment 3 Richard Pinnell 2004-06-30 17:52:38 UTC
Hello Ok I just downloaded the xorg-x11 sources applied your patch and compiled.
 After compilation the screen was shifted to the left with the left most bits
appearing on the right, just as before.  Did you mean this patch as a fix for
the screen being off centre after I had applied my fix noted above or did you
mean it as a fix for the orignal screen shift.  I'm going to download the cvs
source now and compile that with both my fix plus yours to see what happens.  As
for the blue lines in the xv video I fixed them with the folowing simple lines
in the xorg.conf:
Option    "XvHsync"               "-2"
Option    "XvVsync"               "3"
Thanks(In reply to comment #2)
> Created an attachment (id=434)
> Centre the screen for 1400x1050 modes
> 
> Thanks for this report Richard.
> 
> Can you try the attached patch and let me know if it still cures your problem.

(In reply to comment #2)
> Created an attachment (id=434)
> Centre the screen for 1400x1050 modes
> 
> Thanks for this report Richard.
> 
> Can you try the attached patch and let me know if it still cures your problem.
Comment 4 Alan Hourihane 2004-07-01 02:39:04 UTC
The patch was to try and fix the screen shift without commenting out existing 
code like you did in your fix.

You should not apply both yours and my fix at the same time.
Comment 5 Erik Andren 2006-03-12 23:26:19 UTC
Did Alans patch resolve the problem?
Comment 6 Richard Pinnell 2006-03-12 23:51:15 UTC
(In reply to comment #5)
> Did Alans patch resolve the problem?
No The patch did not fix the problem I still have the Laptop I'm using my own fix ie
Locate the lines:
fullSize = (mode->HDisplay == LCD[i].display_x) 
	        && (mode->VDisplay == LCD[i].display_y);
in the trident_dac.c file and comment them out.
Comment 7 Dennis G. 2006-07-08 16:04:24 UTC
I have a similiar bug with this driver. But it seems it is distro-related, or 
just in combination with some other packages (I just cant find out which..)

For me on a 1024x768 resolution the image is shifted to the right by 2 or 3 
pixels. So at the left side there are 2 black lines and at the right there are 
2 lines missing..

I have a trident cyberblade i1..
The bug occurs in the actual kubuntu (6.0.6+updates) for me, but not in the 
actual knoppix (5.0.1). I used the driver of knoppix in kubuntu, but it didnt 
fix it, I also tried the xorg.conf of knoppix in kubuntu and it didnt fix it. 
Maybe it's a bug in another component not correctly working together with this 
driver?
Comment 8 Mike G. 2006-07-10 21:09:00 UTC
(In reply to comment #7)
> For me on a 1024x768 resolution the image is shifted to the right by 2 or 3 
> pixels. So at the left side there are 2 black lines and at the right there are 
> 2 lines missing..

I'm seeing the same thing on my HP Pavilion N3370 laptop, which uses a
Cyberblade/i7d and a 1024x768 screen, running Ubuntu 5.10.  The VESA driver
works fine, and no amount of mucking about with xorg.cfg made any noticable
difference (good or bad) with the trident driver.
Comment 9 Alan Hourihane 2006-10-02 01:28:27 UTC
*** Bug 8338 has been marked as a duplicate of this bug. ***
Comment 10 Daniel Stone 2007-02-27 01:23:22 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 11 Jeremy Huddleston Sequoia 2011-10-03 10:00:43 UTC
Is this still an issue?
Comment 12 Adam Jackson 2018-06-12 19:07:16 UTC
Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.