Bug 4315

Summary: non-endian safe code in >=6.8.99.7 flips rgb->bgr color output in gtk and qt icon pixmaps
Product: xorg Reporter: Stephen P. Becker <geoman>
Component: Driver/newportAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: high CC: ajax, dberkholz, joshuabaergen
Version: git   
Hardware: SGI   
OS: Linux (All)   
URL: http://beerandrocks.net:8080/~spbecker/wtf.png
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    
Attachments:
Description Flags
fixes endian problem with swapped r and b colors none

Description Stephen P. Becker 2005-08-30 16:50:33 UTC 
See the URL for a screenshot of the problem.  Basically, the r and b colors are
swapped in icons displayed within gtk+2 and qt applications, causing them to be
highlighted by awful cyan colors.  We've been trying to figure this problem out
for a while.  I was able to track down the xorg revision where the problem first
showed up to 6.8.99.7.  Initially I thought this problem only affected the
newport driver for SGI Indy, however a developer who is working on a driver for
ImpactSR graphics in Octane machines ran into the same problem.  This bug has
also been confirmed to affect ffb2+ on sparc, and probably many other graphics
devices on big endian arches.

However, Stanislaw Skowronek, who is working on a driver for ImpactSR, came up
with a very simple patch today that fixes all of our problems.  It is attached
to this bug, and should apply to 6.8.99.7 up through HEAD.
Comment 1 Stephen P. Becker 2005-08-30 16:52:13 UTC 
Created attachment 3129 [details] [review]
fixes endian problem with swapped r and b colors
Comment 2 Joshua Baergen 2005-09-01 18:24:51 UTC 
Adding myself to CC.

The line #s differ on the current CVS tree.  s/1017/1022/ and s/1026/1031/
Comment 3 Daniel Stone 2005-09-06 21:24:41 UTC 
fixed in HEAD, thanks (proper attribution to be committed in a sec)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.