| Summary: | Clean up OSL_ASSERT, DBG_ASSERT, etc. | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Stephan Bergmann <sbergman> |
| Component: | Libreoffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | ashodnakashian, bjoern.michaelsen, dtardon, libreoffice, m.weghorn, thumperward |
| Version: | Master old -3.6 | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | https://wiki.documentfoundation.org/Development/GeneralProgrammingGuidelines#Assertions_and_Logging | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=39425 | ||
| Whiteboard: | EasyHack DifficultyBeginner SkillCpp TopicCleanup target:4.1.0 target:4.2.0 target:4.3.0 target:4.4.0 | ||
| i915 platform: | i915 features: | ||
|
Description
Stephan Bergmann
2011-11-22 01:27:23 UTC
Further, sal_detail_logFormat in sal/log.h has a commented-out GCC __attribute__((format)), to catch misuses of its printf-style message composition. It is used by the SAL_WARN and SAL_INFO macros, which in turn is used by the obsoleted OSL_TRACE, for which many calls currently use ill-formed format strings. Once those uses are cleaned up (preferably by replacing them with SAL_INFO_S), the __attribute__((format)) should be enabled. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e4429d43f55c52f16130a745d428b89cbf2f0394 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4bca924dd7ebe1b57f15de3e741f0fffcb67225 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 39425 has been marked as a duplicate of this bug. *** Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f9aabc714af41d7c3dd5cd08b6dc0761db904c4d fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4f727f7bfc848deb82e4df4c6e3b9affaf5f613 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef1d096ddc311a2fd821d4076421c4a8f8d63abf fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a3d299e15526fdcbcaae269e33a83a9c0b187a5a fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b20e7e1d11c8765116c415d7dabd3602d88d1103 fdo#43157 - Clean up OSL_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d461088eb4dd3b3bf7c2caaab082890ebcf80fea fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=671b73789b2b09384e278efa0b989560b6606e4f fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Radu Ioan committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac937d8be69953abcaf1365644c6607c279f37a6 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Honza HavliÄek committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d7b48d03e19d2c05ecf2143b1547ceab5ab89e5c fdo#43157 - Clean up OSL_ENSURE The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Jacobo Aragunde Perez committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=723afc607ec3e947afa0f2122751ea537bca62bd fdo#43157 - Clean up OSL_ENSURE The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details Timothy Markle committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=995073b08e69f6616479f5dd4d4094d96f893207 fdo#43157 - Clean up OSL_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to comment #0) > See > <https://wiki.documentfoundation.org/Development#Assertions_and_Logging>, > the mail thread at > <http://lists.freedesktop.org/archives/libreoffice/2011-November/020864. > html>, and the documentation in the sal/log.h header for further information. The first of those links got stale, use <https://wiki.documentfoundation.org/Development/GeneralProgrammingGuidelines#Assertions_and_Logging> now (as reflected in this issue's URL field now). Thanks to Caolán for spotting. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c03c9da8c249c2e2a61bab3d6fad325d5934f5e0 fdo#43157 : clean up OSL_POSTCOND The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=453ee351f32494b1f30b477069cc7a1834352377 fdo#43157 : clean up more OSL_POSTCOND The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=22ab56f5e35dff58e1923b693dc33ff252293557 fdo#43157 : clean up OSL_DEBUG_ONLY The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=df2c663fef3435a8c3d541b364780876229ccd29 fdo#43157 [API CHANGE] Remove deprecated _OSL_GLOBAL The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=fe075edc27a1fc301c31cfdff5ddbc83e52d929f fdo#43157 : [API CHANGE] Remove OSL_THIS_FILE The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Michaël Lefèvre committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=70e744b2157ebe48f3a5c839560fedf6521d0464 fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. (In reply to comment #0) > The assertion/logging functionality from osl/diagnose.h (OSL_TRACE, > OSL_ASSERT, OSL_ENSURE, OSL_FAIL) and tools/debug.hxx (DBG_ASSERTWARNING, > DBG_ASSERT, DBG_BF_ASSERT, DBG_WARNING, DBG_WARNING1--5, DBG_WARNINGFILE, > DBG_ERRORFILE) is obsolete and needs to be cleaned up: > > * To assert invariants of the code (that can only be violated if there are > programming errors) use standard C/C++ assert. > > * To log warnings about unusual events (that the code nevertheless needs to > handle in some way, like malformed input or I/O failures), use the > SAL_WARN... macros from sal/log.h. > > * To log other information useful for debugging, use the SAL_INFO... macros. > > See > <https://wiki.documentfoundation.org/Development#Assertions_and_Logging>, > the mail thread at > <http://lists.freedesktop.org/archives/libreoffice/2011-November/020864. > html>, and the documentation in the sal/log.h header for further information. In spite of the fact that many people uploaded commits I found that in some files these obsolete assertions/logging. I am going to change as many of these files as I can. Mukhiddin Yusupov committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0562a17c64f4016f2d3ba01e1c19c27feadb2543 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=92621df9e72b9d4e44e448f92df14c4ba731d5e4 Revert "fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT" The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Mukhiddin Yusupov committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4c05911b7ef25505acacbb81053a56cf428e9edc fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. NEEDINFO->NEW: The NEEDINFO state seems to have happened accidentally. Naruhiko Ogasawara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=922f2005f34589e60969be3f2bf74e4af58e2e69 fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 88309 has been marked as a duplicate of this bug. *** (In reply to Stephan Bergmann from comment #0) > See > <https://wiki.documentfoundation.org/Development#Assertions_and_Logging> ...which has moved to <https://wiki.documentfoundation.org/Development/GeneralProgrammingGuidelines#Assertions_and_Logging> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.