Bug 43320

Summary:

cannot build xvfb without xorg (./configure --disable-xorg --enable-xvfb)

Product:

xorg

Reporter:

XU Benda <heroxbd>

Component:

Build/Modular

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Version:

git

Hardware:

All

OS:

Linux (All)

Whiteboard:

2011BRB_Reviewed

i915 platform:

i915 features:

Attachments:

Description	Flags
config.log	none
build log	none

Description XU Benda 2011-11-28 19:46:47 UTC

I want a minimal setup of X on a headless server, with xpra[1]. I need only xvfb and keyboard drivers. But ./configure --disable-xorg --enable-xvfb fails. The build error is related to this commit[2]. Not sure what it means by "otherwise installing non-xorg servers breaks."

The config.log and building log are attached. A Gentoo bug[3] also tracks this issue.

1. xpra.org
2. http://webcvs.freedesktop.org/xorg/xserver/xorg/include/Makefile.am?revision=1.5&view=markup
3. https://bugs.gentoo.org/show_bug.cgi?id=381771

Comment 1 XU Benda 2011-11-28 19:48:20 UTC

Created attachment 53922 [details]
config.log

Comment 2 XU Benda 2011-11-28 19:48:44 UTC

Created attachment 53923 [details]
build log

Comment 3 Alan Coopersmith 2011-11-28 19:51:00 UTC

As the webcvs page notes, the Xorg CVS repo has been abandoned for years, as
we now use git, and that commit has nothing to do with building the test
programs that were added years after the move to git.

Comment 4 XU Benda 2011-11-28 20:10:01 UTC

(In reply to comment #3)
> As the webcvs page notes, the Xorg CVS repo has been abandoned for years, as
> we now use git, and that commit has nothing to do with building the test
> programs that were added years after the move to git.

okay, I have found the git correspondence, http://cgit.freedesktop.org/xorg/xserver/commit/?id=506eca5f57b960a6650c3387047a6ae8a22181e9

Comment 5 Alan Coopersmith 2011-11-28 20:43:00 UTC

(In reply to comment #4)
> (In reply to comment #3)
> > As the webcvs page notes, the Xorg CVS repo has been abandoned for years, as
> > we now use git, and that commit has nothing to do with building the test
> > programs that were added years after the move to git.
> 
> okay, I have found the git correspondence,
> http://cgit.freedesktop.org/xorg/xserver/commit/?id=506eca5f57b960a6650c3387047a6ae8a22181e9

While that is the corresponding git commit to the one you previously found,
that's still not the cause of this problem, as that fixed a problem with
installation of header files when --disable-xorg was passed, while your
build logs show errors in building the test cases due to a missing generated
source file.

Comment 6 Alan Coopersmith 2011-11-28 20:43:16 UTC

Confirmed bug exists in git master.

Simple workaround: add --disable-unit-tests to configure options

Patch to really fix submitted for review:
http://patchwork.freedesktop.org/patch/8013/

Comment 7 XU Benda 2011-11-28 23:31:50 UTC

(In reply to comment #6)
> Confirmed bug exists in git master.
> 
> Simple workaround: add --disable-unit-tests to configure options
> 
> Patch to really fix submitted for review:
> http://patchwork.freedesktop.org/patch/8013/

Patch tested to work. You rock!

BTW, shall I close this bug now, or until the patch accepted in the master branch?

> (In reply to comment #5)
> While that is the corresponding git commit to the one you previously found,
> that's still not the cause of this problem, as that fixed a problem with
> installation of header files when --disable-xorg was passed, while your
> build logs show errors in building the test cases due to a missing generated
> source file.

Hmm, you are right. Thanks a lot for your explanation.

Comment 8 Alan Coopersmith 2011-11-28 23:33:51 UTC

(In reply to comment #7)
> BTW, shall I close this bug now, or until the patch accepted in the master
> branch?

I'll take care of that once the patch is reviewed & accepted.

Comment 9 Jeremy Huddleston Sequoia 2012-01-02 12:36:35 UTC

This is already on master (for 1.12)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.