Bug 43324

Summary: [bisected SNB] Oglc float-texture(mipmap.automatic) fails
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Mesa coreAssignee: Ian Romanick <idr>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: high CC: chadversary, eric
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    

Description fangxun 2011-11-29 01:34:13 UTC 
System Environment:
--------------------------
Arch:           i386
Platform:       huronriver
Libdrm:         (master)2.4.27-2-gca4971292cf99e0063416cd1c3467af94637bf2b
Mesa:           (master)d4fcf67a3ac78c29448000486dadc2b4b1b2a56d
Xserver:      
(master)xorg-server-1.11.99.1-43-gb2015a2c01711646bb7ae23d684abee0cd55d4d0
Xf86_video_intel: (master)2.17.0-26-g16f5e224dcfd97012b38ee1af6c72dbe3c0f3304
Kernel:  (drm-intel-next)9a10f401a401ca69c6537641c8fc0d6b57b5aee8


Bug detailed description:
------------------------- 
Bisect shows 05ab8fc13461aa9d6612d75c899dac20de067da6 is the first bad commit.
commit 05ab8fc13461aa9d6612d75c899dac20de067da6
Author:     Eric Anholt <eric@anholt.net>
AuthorDate: Tue Nov 15 12:49:25 2011 -0800
Commit:     Eric Anholt <eric@anholt.net>
CommitDate: Tue Nov 22 13:58:38 2011 -0800

    intel: Remove duplicate test for texture attachment completeness.

    We are already testing this if appropriate in
    intel_validate_framebuffer (FBO completeness), so no need to avoid
    attaching the texture to the renderbuffer here.

    This causes MESA_FORMAT_R11_G11_B10_FLOAT to now be renderable as a texture
    attachment on i965.

    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>


Reproduce steps:
----------------
1. start X
2. ./oglconform -z -s -suite all -v 2 -D 115 -test float-texture mipmap.automatic
Comment 1 Paul Berry 2012-01-17 16:05:06 UTC 
I reproduced the failure on my machine and got a little bit more information.

The failing test generates textures with various texture types and internal formats, with the texture parameter GL_GENERATE_MIPMAP_SGIS enabled.  This should cause a mipmap to be automatically generated.  It then checks that all mipmap levels have been generated correctly by using the texture for drawing.

The segfault only happens when testing GL_TEXTURE_3D with one of the following internal formats:

GL_LUMINANCE_ALPHA16F_ARB
GL_R16F
GL_INTENSITY16F_ARB
GL_RG16F
GL_LUMINANCE16F_ARB
GL_ALPHA16F_ARB

Note: this is the same list as for bug 43325, but with the addition of GL_ALPHA16F_ARB.

I checked whether Brian Paul's "renderbuffer-cleanups-v2" branch fixes any of these failures.  It doesn't.

As with bug 43325, I'm not familiar enough with the Mesa mipmap code to fix this bug.  In the long run I would like to make a Piglit test that reproduces it, but that will take some time since at the moment all of our existing mipmap tests are 2D-only.  So I'm going to work on some other bugs first.
Comment 2 Ian Romanick 2012-02-01 13:25:09 UTC 
Patch sent to the mesa-dev list.

http://lists.freedesktop.org/archives/mesa-dev/2012-February/018566.html
Comment 3 Ian Romanick 2012-02-02 11:00:44 UTC 
Fixed on the 8.0 branch by:

commit 4635e26db23dae60b7586995eb3cf27cb9841443
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Wed Feb 1 14:19:35 2012 -0700

    mesa: Fix copy-and-paste bug in do_row_3D
    
    Several of the half-float cases used 4 as the texel size when it
    should have been some smaller value.
    
    NOTE: This is a candidate for the 8.0 branch.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43324
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43325
    (cherry picked from commit 5c341b7df3c1058d586629394e53e9e26ae2cc01)
Comment 4 fangxun 2012-02-08 01:58:28 UTC 
It still fails on mesa master and 8.0 branch.
Comment 5 Ian Romanick 2012-02-08 11:59:29 UTC 
This bug has always had the same root cause as bug #43325, so I am closing this as a duplicate.

*** This bug has been marked as a duplicate of bug 43325 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.