Bug 43353

Created attachment 53962 [details]
bgra-vert-attrib-pointer.png

mesa: ccd4d4367f2b4e5aebfc59b832599812a4a1c7d8 (master)

Run piglit bgra-vert-attrib-pointer on swrast.

$ ./bin/bgra-vert-attrib-pointer -auto
Probe at (200,200)
  Expected: 1.000000 0.000000 0.000000
  Observed: 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
762c9766c93697af8d7fbaa729aed118789dbe8e
76ba431b97087e2d5ca0351e0d613f0812fd1425
We cannot bisect more!
bisect run cannot continue any more



commit 762c9766c93697af8d7fbaa729aed118789dbe8e
Author: Mathias Fröhlich <Mathias.Froehlich@web.de>
Date:   Mon Oct 31 22:23:51 2011 +0100

    mesa: Use VERT_ATTRIB_* indexed array in gl_array_object.
    
    Replace the distinct struct gl_client_array members in gl_array_object by
    an array of gl_client_arrays indexed by VERT_ATTRIB_*.
    Renumber the vertex attributes slightly to keep the old semantics of the
    distinct array members. Make use of the upper 32 bits in VERT_BIT_*.
    Update all occurances of the distinct struct members with the array
    equivalents.
    
    Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
    Reviewed-by: Eric Anholt <eric@anholt.net>


commit 76ba431b97087e2d5ca0351e0d613f0812fd1425
Author: Chia-I Wu <olv@lunarg.com>
Date:   Tue Nov 29 15:19:28 2011 +0800

    mesa: distinct gl_client_array arrays are gone
    
    Fix build errors since 762c9766c93697af8d7fbaa729aed118789dbe8e.
    
    Acked-by: Jose Fonseca <jfonseca@vmware.com>

(In reply to comment #3)
> There are only 'skip'ped commits left to test.
> The first bad commit could be any of:
> 762c9766c93697af8d7fbaa729aed118789dbe8e
> 76ba431b97087e2d5ca0351e0d613f0812fd1425
> We cannot bisect more!
> bisect run cannot continue any more

Vinson,

If you apply Chia-I Wu's commit w/ build fix by doing

  git bisect ...

  git cherry-pick -n 76ba431b97087e2d5ca0351e0d613f0812fd1425 
  ... # test
  git reset --hard HEAD

  and so on

then it should be possible to bisect further.

Created attachment 53992 [details] [review]
Renumber tnl attributes patch.

Vinson,

Does the attached patch help for your problem?

Mathias

(In reply to comment #5)
> Created attachment 53992 [details] [review] [review]
> Renumber tnl attributes patch.
> 
> Does the attached patch help for your problem?
> 

Patch 53992 fixes the swrast piglit bgra-vert-attrib-pointer regression.

Tested-by: Vinson Lee <vlee@vmware.com>

A slightly reworked change is upstream with:

commit ce45aecfdab9926b767d9924bddbc4304d59641c.

Closing this.
Thanks!

Mathias

mesa: ce45aecfdab9926b767d9924bddbc4304d59641c (master)

Verified fixed.

Thanks Mathias!