Bug 43402

Summary: [bisected pineview] piglit spec/glsl-1.10/execution/variable-indexing/fs-varying-mat2-col-rd fails
Product: Mesa Reporter: fangxun <xunx.fang>
Component: Drivers/DRI/i915Assignee: Ian Romanick <idr>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: Mathias.Froehlich
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 42993    

Description fangxun 2011-11-30 22:05:41 UTC
System Environment:
--------------------------
Arch:           i386
Platform:       pineview
Libdrm:         (master)2.4.27-3-g37ccce5e390a9d757474920f488cafa1cf89854a
Mesa:           (master)2134d2f35baadf4117e48aa3315608403622b79a
Xserver: (master)xorg-server-1.11.99.1-43-gb2015a2c01711646bb7ae23d684abee0cd55d4d0
Xf86_video_intel:  (master)2.17.0-41-gd8f2e87473eae81e07922271b5f608fdceb4ae5e
Kernel:  (drm-intel-next)9a10f401a401ca69c6537641c8fc0d6b57b5aee8

Bug detailed description:
------------------------- 
It fails on pineview.  Bisect shows 143d20c16a33e2f08e834b28c23dbea772591ef9 is the first bad commit.
commit 762c9766c93697af8d7fbaa729aed118789dbe8e
Author:     Mathias Fröhlich <Mathias.Froehlich@web.de>
AuthorDate: Mon Oct 31 22:23:51 2011 +0100
Commit:     Mathias Fröhlich <Mathias.Froehlich@web.de>
CommitDate: Tue Nov 29 06:37:19 2011 +0100

    mesa: Use VERT_ATTRIB_* indexed array in gl_array_object.

    Replace the distinct struct gl_client_array members in gl_array_object by
    an array of gl_client_arrays indexed by VERT_ATTRIB_*.
    Renumber the vertex attributes slightly to keep the old semantics of the
    distinct array members. Make use of the upper 32 bits in VERT_BIT_*.
    Update all occurances of the distinct struct members with the array
    equivalents.

    Signed-off-by: Mathias Froehlich <Mathias.Froehlich@web.de>
    Reviewed-by: Eric Anholt <eric@anholt.net>

Below cases also fail due to the bisect commit.
piglit cases:
spec/glsl-1.10/execution/built-in-functions/vs-op-selection-bool-bool-bool-using-if
spec/glsl-1.10/execution/built-in-functions/vs-op-sub-int-int
spec/glsl-1.10/execution/built-in-functions/vs-op-uplus-ivec4
spec/glsl-1.10/execution/built-in-functions/vs-refract-float-float-float
spec/glsl-1.10/execution/built-in-functions/vs-refract-vec2-vec2-float
spec/glsl-1.10/execution/built-in-functions/vs-refract-vec3-vec3-float
spec/glsl-1.10/execution/built-in-functions/vs-refract-vec4-vec4-float
spec/glsl-1.10/execution/samplers_normal-parameter
spec/glsl-1.10/execution/variable-indexing/fs-varying-array-mat2-row-rd
spec_glsl-1.10/execution/variable-indexing/vs-temp-array-mat2-rd
spec/glsl-1.10/execution/variable-indexing/vs-temp-array-mat4-rd
spec/glsl-1.10/execution/variable-indexing/vs-varying-mat4-col-rd

oglc cases:
displaylist-deref(misc.vertexAttribDereference)
ver_colormat(basic.immediateModePrimitives)
GLSLlinker(positive.basic.linkingOperation.useWhileDeletingProgramAndShaders)
GLSLlinker(positive.basic.linkingOperation.useWhileDeletingShaders)
GLSLlinker(volume.varying.8vec4)
max_values(advanced.vertexAttribs)

Ogles2conform cases:
GL2ExtensionTests/depth_texture_depth/texture.test
GL2ExtensionTests/egl_image/egl_image.test
GL2ExtensionTests/packed_depth_stencil/packed_depth_stencil.test
GL2FixedTests/blend_blend.test
GL2FixedTests/buffer_color/buffer_color.test
GL2FixedTests/buffer_objects/buffer_objects.test
GL2FixedTests/color_ramp_color/ramp.test
GL2FixedTests/copy_texture/copy_texture.test
GL2FixedTests/depth_buffer_functions/depth_buffer_functions.test
GL2FixedTests/mipmaps_selection/mipmaps_selection.test
GL2FixedTests/stencil_plane_operation/stencil_plane_operation.test
GL2Tests/framebuffer_objects/framebuffer_objects.test
GL2Tests/glUniform_glUniform.test
GL/read_format/read_format.test
GL/swizzlers_vec3/stp_1vec3_vert.test

Reproduce steps:
----------------
1. start X
2. ./shader_runner tests/spec/glsl-1.10/execution/variable-indexing/fs-varying-mat2-col-rd.shader_test -auto -fbo
Comment 1 Mathias Fröhlich 2011-12-01 22:35:24 UTC
At least classic swrast passes.
Lacking a reachable i915:
Does commit ce45aecfdab9926b767d9924bddbc4304d59641c fix this issue?

Mathias
Comment 2 fangxun 2011-12-05 01:18:43 UTC
It fixes this issue.
Comment 3 fangxun 2011-12-05 01:19:55 UTC
Verified with Mesa master commit b7a69cbb71304609245be43fa739c50969017ab8.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.