Bug 43604

Summary:	ChangeHosts incorrectly encodes address as a string, not a binary blob
Product:	XCB	Reporter:	Robert Ancell <robert.ancell>
Component:	Protocol	Assignee:	xcb mailing list dummy <xcb>
Status:	RESOLVED FIXED	QA Contact:	xcb mailing list dummy <xcb>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Robert Ancell 2011-12-07 15:08:13 UTC

ChangeHosts incorrectly encodes address as a string, not a binary blob.  It should be the same as in the HOSTS structure:

--- a/src/xproto.xml
+++ b/src/xproto.xml
@@ -2295,7 +2298,7 @@ authorization from the authors.
     <field type="CARD8" name="family" enum="Family" />
     <pad bytes="1" />
     <field type="CARD16" name="address_len" />
-    <list type="char" name="address">
+    <list type="BYTE" name="address">
       <fieldref>address_len</fieldref>
     </list>
   </request>

Comment 1 Julien Danjou 2012-01-11 08:04:55 UTC

Patch merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.