Bug 43605

Summary:	XKB-SetControls has some incorrectly named fields
Product:	XCB	Reporter:	Robert Ancell <robert.ancell>
Component:	Protocol	Assignee:	xcb mailing list dummy <xcb>
Status:	RESOLVED FIXED	QA Contact:	xcb mailing list dummy <xcb>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Robert Ancell 2011-12-07 15:10:14 UTC

XKB-SetControls has some incorrectly named fields according to the spec, interanlRealMods -> internalRealMods, Internal where Ignore should be used.

--- a/src/xkb.xml
+++ b/src/xkb.xml
@@ -1222,13 +1223,13 @@ authorization from the authors.
        <request name="SetControls" opcode="7">
                <field name="deviceSpec" type="DeviceSpec" />
                <field name="affectInternalRealMods" type="CARD8" mask="ModMask" />
-               <field name="interanlRealMods" type="CARD8" mask="ModMask" />
+               <field name="internalRealMods" type="CARD8" mask="ModMask" />
                <field name="affectIgnoreLockRealMods" type="CARD8" mask="ModMask" />
                <field name="ignoreLockRealMods" type="CARD8" mask="ModMask" />
                <field name="affectInternalVirtualMods" type="CARD16" mask="VMod" />
                <field name="internalVirtualMods" type="CARD16" mask="VMod" />
-               <field name="affectInternalLockVirtualMods" type="CARD16" mask="VMod" />
-               <field name="internalLockVirtualMods" type="CARD16" mask="VMod" />
+               <field name="affectIgnoreLockVirtualMods" type="CARD16" mask="VMod" />
+               <field name="ignoreLockVirtualMods" type="CARD16" mask="VMod" />
                <field name="mouseKeysDfltBtn" type="CARD8" />
                <field name="groupsWrap" type="CARD8" />
                <field name="accessXOptions" type="AXOption" />

Comment 1 Julien Danjou 2012-01-11 08:16:40 UTC

Patch merged.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.