| Summary: | squashfs MIME type. | ||
|---|---|---|---|
| Product: | shared-mime-info | Reporter: | dE <de.techno> |
| Component: | freedesktop.org.xml | Assignee: | Shared Mime Info group <shared_mime_info> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | bugzilla, robert.ancell |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Add application/vnd.squashfs
Add application/vnd.squashfs Add application/vnd.squashfs Add application/vnd.snap Add application/vnd.snap |
||
|
Description
dE
2011-12-08 01:04:29 UTC
Please read http://cgit.freedesktop.org/xdg/shared-mime-info/tree/HACKING about adding new mime-types. My main concern is - * Mime-types used should be IANA registered mime-types when possible So is this mandatory? If so, I think it as impossible to convince people of IANA. (In reply to comment #2) > My main concern is - > > * Mime-types used should be IANA registered mime-types when possible > > So is this mandatory? If so, I think it as impossible to convince people of > IANA. The fact that it says "when possible" is a pretty clear pointer that this isn't mandatory. Created attachment 124105 [details] [review] Add application/vnd.squashfs Comment on attachment 124105 [details] [review] Add application/vnd.squashfs Review of attachment 124105 [details] [review]: ----------------------------------------------------------------- What is this useful for? How is this different from the disk image mime-type (apart from the magic), and why wouldn't it descend from it? Are we going to have to add every filesystem out there? > What is this useful for? In my case, this is useful for viewing .snap files which a squashfs file. It's also used for other cases such as firmware updates, disk images and a general archive format. I've added this so file-roller can open these files (https://bugzilla.gnome.org/show_bug.cgi?id=662519) > How is this different from the disk image mime-type (apart from the magic), > and why wouldn't it descend from it? > Are we going to have to add every filesystem out there? While it's described as a file system it's use is more like an archive that can happen to be mounted / unpacked as a filesystem. It's more similar to a .dmg / .tar.gz than an EXT4 image. Info about .snap: http://askubuntu.com/questions/761245/what-is-the-snap-packaging-format I just saw that you don't have any test files. Please check the HACKING file again about how to add those and test that they're well integrated into the system. Created attachment 124120 [details] [review] Add application/vnd.squashfs Added test file. Note the tests fail because the previous commit for application/raml+yaml seems to be missing their test file.. (In reply to Robert Ancell from comment #9) > Created attachment 124120 [details] [review] [review] > Add application/vnd.squashfs > > Added test file. Note the tests fail because the previous commit for > application/raml+yaml seems to be missing their test file.. That last commit is reverted, but that's still not enough: image.sqsh, 'name' test: expected application/vnd.squashfs, got application/octet-stream Created attachment 124169 [details] [review] Add application/vnd.squashfs Ah, I see. The tests require an extension. Seems to work now. Created attachment 124170 [details] [review] Add application/vnd.snap Related to the last patch - this recognises *.snap as a snap package (which is itself is just a squashfs file) example_42_all.snap, 'data' test: expected application/vnd.snap, got application/vnd.squashfs Can you please test your patches before attaching them? Comment on attachment 124169 [details] [review] Add application/vnd.squashfs Attachment 124169 [details] pushed as e96df89 - Add application/vnd.squashfs Created attachment 124174 [details] [review] Add application/vnd.snap Apologies, I did not read the output of make clearly enough... Attachment 124174 [details] pushed as 4882ca0 - Add application/vnd.snap
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.