Bug 43791

Summary:	Make usage of GSettings key/schema a compile option
Product:	Telepathy	Reporter:	Mikhail Zabaluev <mikhail.zabaluev>
Component:	mission-control	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	Keywords:	patch
Version:	git master
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~zabaluev/telepathy-mission-control/log/?h=optionalize-gsettings
Whiteboard:	review+
i915 platform:		i915 features:

Description Mikhail Zabaluev 2011-12-13 05:54:44 UTC

With the current implementation for bug #42068, telepathy-mission-control aborts if the settings schema 'im.telepathy.MissionControl.FromEmpathy' is not installed.

From the motivation for the key, it is not necessary for Mission Control to work properly. Therefore, absence of the key, or the schema, or any GSettings backend for that matter, should not abort it.

Comment 1 Mikhail Zabaluev 2011-12-13 07:34:42 UTC

I guess it can be made to "always" work if glib-compile-schemas is invoked after installation of telepathy-mission-control. GSettings should always have some backend, so there is no extra implicit dependency on e.g. dconf.

Comment 2 Mikhail Zabaluev 2012-01-18 08:39:23 UTC

I'm converting this bug to a request for a configure option to disable usage of GSettings, which I have implemented:

http://cgit.freedesktop.org/~zabaluev/telepathy-mission-control/log/?h=optionalize-gsettings

Comment 3 Simon McVittie 2012-01-19 01:43:49 UTC

Looks OK to me.

Comment 4 Mikhail Zabaluev 2012-01-19 04:26:45 UTC

Thanks, merged and pushed to master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.