Bug 44179

In which conditions this message is sent? It would be helpful to have a test case.

thanks

(In reply to comment #1)
> In which conditions this message is sent? It would be helpful to have a test
> case.
> 
> thanks

-More than 1 guest monitor
- Pixmap cache size exceeds its limit when trying to insert a new bitmap
- As a result the oldest bitmaps in the cache are removed from it
- Each such bitmap occurrence holds for each one of the display channels the serial number of the last message that referred to this cache item.
WAIT_FOR_CHANNELS is sent to client before INVAL_LIST, together with these serial numbers (for all the display channels, except for the one that the message is desalinated to). This way we prevent display channel x from removing bitmap b from the cache, before message m that refers to b arrived to display channel y.
WAIT_FOR_CHANNELS will be sent only if one of the other channels actually used on of the removed cache bitmaps.

In addition, for similar reasons, wait_for_channels should also be called in channel-display::display_handle_inv_pixmap_all before reseting the cache.

Created attachment 55113 [details] [review]
Implement SPICE_MSG_WAIT_FOR_CHANNELS

Created attachment 55114 [details] [review]
Wait for channels before invalidating images

Comment on attachment 55113 [details] [review]
Implement SPICE_MSG_WAIT_FOR_CHANNELS

Review of attachment 55113 [details] [review]:
-----------------------------------------------------------------

Looks good.

Comment on attachment 55114 [details] [review]
Wait for channels before invalidating images

Review of attachment 55114 [details] [review]:
-----------------------------------------------------------------

Looks good

bug 44570 is similar to this bug: not waiting till images that should appear in the cache are actually added to the cache.

committed