Bug 44303

Summary: Call: No way to control the direction of a new Content
Product: Telepathy Reporter: Olivier Crête <olivier.crete>
Component: tp-specAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: git master   
Hardware: Other   
OS: All   
Whiteboard: Call
i915 platform: i915 features:
Attachments: patch to add a Direction to AddContent

Description Olivier Crête 2011-12-29 22:09:05 UTC 
There are 4 different ways a content can be added (at the start of the call or later and by the local side or by the remote side). The spec as currently written doesn't allow to control the initial direction in any of these cases.  suggest the following:

1. Allow calling of SetSending()/RequestReceiving() on initial streams before the Accept() call to set the direction in the initial offer and answer.

2. On streams added after the call is started, set the "LocalSendingState" to PENING_SEND if the other side creates a stream asking us to send.

3. For Contents created with AddContent(), it's a bit touchy.. ie I have no idea how to do it with the current API short of adding another argument to AddContent() or adding a Accept() to the Content itself, all of which is a bit nasty. This is problematic as it could be a privacy leak too... I think we could want to create a stream to just ask the other side to send.
Comment 1 Guillaume Desmottes 2012-02-16 09:18:59 UTC 
Is this considered as a blocker for Call1?
Comment 2 Olivier Crête 2012-02-16 09:44:18 UTC 
Created attachment 57168 [details] [review]
patch to add a Direction to AddContent

Yes, it's a blocker for Call. Here is a spec patch, tp-glib and gabble patches are forthcoming.
Comment 4 Guillaume Desmottes 2012-02-17 02:48:05 UTC 
<sjoerd> the direction one looks good to me as well, but may be useful to add a property for it as well and maybe to the ContentAdded signal
Comment 5 Olivier Crête 2012-02-17 07:32:11 UTC 
Actually, the properties exist, they are "LocalSendingState" and "RemoteMembers" on the Stream object
Comment 6 Guillaume Desmottes 2012-02-20 01:58:38 UTC 
I merged the spec patch to master and the tp-glib and Gabble branches to call1.

I opened bug #46326 about the InitialDirection property requested by Sjoerd.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.