Bug 44519

Summary: translate_test generic regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED MOVED QA Contact:
Severity: critical    
Priority: medium CC: maraeo
Version: 8.0Keywords: bisected, regression
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: add support for half floats

Description Vinson Lee 2012-01-06 00:56:33 UTC 
mesa: 2fe6c254f72628c22473800c5ce002d09391d102 (master)

$ ./build/linux-x86_64-debug/bin/translate_test generic
[...]
PASS: PIPE_FORMAT_R8G8B8A8_SNORM -> PIPE_FORMAT_B8G8R8A8_UNORM -> PIPE_FORMAT_R8G8B8A8_SNORM -> PIPE_FORMAT_B8G8R8A8_UNORM -> PIPE_FORMAT_R8G8B8A8_SNORM
  506f7608 73161827 0b133359 19247f1d 
  ecdea010 302ce64e 662616b2 ff48323a 
* 4f6e7507 72151726 0a123258 18237f1c 
  eadc9e0e 2e2ae44c 642414b0 ff463038 
* 4e6d7406 71141625 09113157 17227f1b 
Aborted (core dumped)


(gdb) bt
#0  0x00007fdbe10e53b5 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fdbe10e8b1b in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x0000000000401d53 in main (argc=2, argv=0x7fff6e4b64d8) at src/gallium/tests/unit/translate_test.c:250
(gdb) frame 2
#2  0x0000000000401d53 in main (argc=2, argv=0x7fff6e4b64d8) at src/gallium/tests/unit/translate_test.c:250
250	            abort();
(gdb) l
245	         if(input_is_float && input_format_desc->channel[0].size == 32)
246	            buffer[0] = (unsigned char*)float_buffer;
247	         else if(input_is_float && input_format_desc->channel[0].size == 64)
248	            buffer[0] = (unsigned char*)double_buffer;
249	         else if(input_is_float)
250	            abort();
251	         else
252	            buffer[0] = byte_buffer;
253	
254	         translate[0]->set_buffer(translate[0], 0, buffer[0], input_format_size, count - 1);
(gdb) print input_is_float
$1 = 1 '\001'
Comment 1 Vinson Lee 2012-01-07 11:43:26 UTC 
1acef6a7465e8c54dc10a43c9e7278d4506c1d5e is the first bad commit
commit 1acef6a7465e8c54dc10a43c9e7278d4506c1d5e
Author: Marek Olšák <maraeo@gmail.com>
Date:   Sun Jan 1 12:36:44 2012 +0100

    translate: implement translation of half floats in the generic codepath

:040000 040000 d2a2494cb0522780347b2e8b3bddee6c9d00b431 702c30772792649fe2ca33b8b060924b6e569e33 Msrc
bisect run success
Comment 2 Vinson Lee 2012-06-04 23:40:13 UTC 
mesa: 555e00fdc30514b45e9afae18f56a9a4bc65f364

The translate_test unit test is still failing.
Comment 3 Brian Paul 2012-06-05 08:04:50 UTC 
Created attachment 62589 [details] [review]
add support for half floats

Vinson, this patch fixes the abort, but there's still some failing cases for 'generic'.
Comment 4 Vinson Lee 2014-09-13 07:55:43 UTC 
mesa: 9133784a46b314389b21b8566d821a480edc2cb0 (master 10.4.0-devel)

Regression is still present.
Comment 5 GitLab Migration User 2019-09-18 20:17:00 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/897.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.